Skip to content

Commit

Permalink
fix(iroh-net): Fix a compiler error with newer derive_more versions (
Browse files Browse the repository at this point in the history
…#2578)

## Description

<!-- A summary of what this pull request achieves and a rough list of
changes. -->
The `#[derive(Debug)]` used to generate an impl like this:
```rust
#[automatically_derived]
impl<'a> ::core::fmt::Debug for Accept<'a>
where
    quinn::Accept<'a>: ::core::fmt::Debug,
    Endpoint: ::core::fmt::Debug,
{
// ...
}
```

But `quinn::Accept` doesn't implement `Debug`.

## Breaking Changes

<!-- Optional, if there are any breaking changes document them,
including how to migrate older code. -->
None

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->
I'm... Really stumped on what changed in `derive_more`. When I expand
the macro, in both versions there's a `Debug` bound on `quinn::Accept`,
which just can't be right... Anyhow.

## Change checklist

- [X] Self-review.
- ~~[ ] Documentation updates following the [style
guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text),
if relevant.~~
- ~~[ ] Tests if relevant.~~
- [X] All breaking changes documented.
  • Loading branch information
matheus23 authored Aug 2, 2024
1 parent 01dd3d5 commit e050243
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit e050243

Please sign in to comment.