Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactions are drawn below the message bubble #4235

Closed
link2xt opened this issue Oct 21, 2024 · 1 comment · Fixed by #4237
Closed

Reactions are drawn below the message bubble #4235

link2xt opened this issue Oct 21, 2024 · 1 comment · Fixed by #4237
Assignees
Labels
bug Something isn't working

Comments

@link2xt
Copy link
Collaborator

link2xt commented Oct 21, 2024

emoji

This is with commit 1ebcc5a

@WofWca
Copy link
Collaborator

WofWca commented Oct 22, 2024

To clarify, this is about the next message covering up the reactions of the previous one

This likely has been worsened in #4120 where I removed the bottom margin.

One issue here is that the metadata for an image with no captions has position: absolute;, thus it doesn't get included in the normal flow:

This is how it looks on 1.46.8:

image

@r10s r10s added the bug Something isn't working label Oct 22, 2024
@WofWca WofWca self-assigned this Oct 22, 2024
WofWca added a commit that referenced this issue Oct 22, 2024
Closes #4235

The issue probably existed ever since the reactions were added
in the first place #2964,
but it got worse after the removal of margin addition
when adding a reaction (60e52c7).

This should make things simpler as all positioning-related stuff
is only done in `message/styles.module.scss`.
WofWca added a commit that referenced this issue Oct 22, 2024
Closes #4235

The issue probably existed ever since the reactions were added
in the first place #2964,
but it got worse after the removal of margin addition
when adding a reaction (60e52c7).

This should make things simpler as all positioning-related stuff
is only done in `message/styles.module.scss`.
WofWca added a commit that referenced this issue Oct 22, 2024
Closes #4235

The issue probably existed ever since the reactions were added
in the first place #2964,
but it got worse after the removal of margin addition
when adding a reaction (60e52c7).

This commit should make things simpler
because all positioning-related stuff
is only done in `message/styles.module.scss`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants