Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double colon and parametric node collision #242

Conversation

ivan-tymoshenko
Copy link
Collaborator

Fixed #241

This is not the best solution, but I don't know how to fix it perfectly right now.

@ivan-tymoshenko ivan-tymoshenko marked this pull request as draft March 27, 2022 15:32
@ivan-tymoshenko ivan-tymoshenko force-pushed the fix-double-colon-and-parametric-nodes-collision branch from 3a5d4ce to 0edc491 Compare March 27, 2022 20:45
@ivan-tymoshenko ivan-tymoshenko marked this pull request as ready for review March 27, 2022 20:45
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina requested a review from delvedor March 28, 2022 08:19
Copy link
Owner

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks ok.
Can you post a benchmark that compares this branch and main?

@ivan-tymoshenko
Copy link
Collaborator Author

Main branch:

main

Current branch:

Снимок экрана 2022-03-28 в 14 38 26

Copy link
Owner

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit a7c4216 into delvedor:main Mar 28, 2022
@ivan-tymoshenko ivan-tymoshenko deleted the fix-double-colon-and-parametric-nodes-collision branch April 17, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Broken routing for aliased routes ending with <...>/::something & <...>/:some_var
3 participants