Node insertion optimization #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-tymoshenko
force-pushed
the
refactoring-insert-method
branch
from
5ef0f10 to
28dc50d
Compare
RafaelGSS
reviewed
Mar 29, 2022
delvedor
requested changes
Mar 29, 2022
|
Main branch
Current branch
|
ivan-tymoshenko
force-pushed
the
refactoring-insert-method
branch
from
28dc50d to
6086a3d
Compare
|
Could you rebase? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mention here #242, it wasn't the best solution to this #241 issue. This is much better. I needed to optimize the insert method first. The main idea of optimization is that previously the insertion of each node started at the root of the tree. Now, setting a new node is based on the previous one. This allowed us to simplify the code a lot.