Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Armorblox Cortex Integration #15873

Merged
merged 10 commits into from
Dec 7, 2021
Merged

Armorblox Cortex Integration #15873

merged 10 commits into from
Dec 7, 2021

Conversation

urajat
Copy link
Contributor

@urajat urajat commented Nov 19, 2021 •
edited
Loading

Initial Commit for Cortex Integration
Added README
Deleted www from Armorblox url
Addition of a new command to check remediation actions
Added playbook and changes
Removal of extra space in Armorblox Outbound Threat and renaming MailBox to Mailbox in Armorblox Abuse MailBox Threat
Removed default tenant name
Added changes for testing script
Removed MailBox incident type
Removed unwanted Threat(MailBox and Armorblox Outbound) from mapper
added github users in pack metadata

Co-authored-by: Rajat Upadhyaya 45485+urajat@users.noreply.github.com

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@ankita-sharma2019 @urajat
Armorblox Cortex Integration
819dd60 
Initial Commit for Cortex Integration
Added README
Deleted www from Armorblox url
Addition of a new command to check remediation actions
Added playbook and changes
Removal of extra space in Armorblox Outbound Threat and renaming MailBox to Mailbox in Armorblox Abuse MailBox Threat
Removed default tenant name
Added changes for testing script
Removed MailBox incident type
Removed unwanted Threat(MailBox and Armorblox  Outbound) from mapper
added github users in pack metadata

Co-authored-by: Rajat Upadhyaya <45485+urajat@users.noreply.github.com>
@CLAassistant
Copy link

CLAassistant commented Nov 19, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label Nov 19, 2021
@content-bot content-bot changed the base branch from master to contrib/armorblox_armorblox November 19, 2021 16:11
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @dorschw will know he can start review the proposed changes.

@content-bot content-bot requested a review from dorschw November 19, 2021 16:11
@content-bot
Copy link
Collaborator

The CircleCI check from your latest pushed commit was unsuccessful. @urajat take a look at the build by clicking this link.

Failed Build Steps

  • Validate Files and Yaml
  • Secrets

Try and address the listed CircleCI build step failures at your earliest convenience. This will greatly expedite the process of getting your proposed changes merged into master. Happy coding and may the force be with you.

@dorschw
Copy link
Contributor

dorschw commented Nov 21, 2021

Hi Rajat, thanks for the contribution

Please see this message and fill this form so we can review this PR.

@content-bot content-bot added Contribution Form Filled Whether contribution form filled or not. Partner labels Nov 25, 2021
@urajat urajat marked this pull request as ready for review November 25, 2021 16:06
ankita-sharma2019 and others added 2 commits December 1, 2021 14:16
@ankita-sharma2019 @urajat
Removed unintentional '}'
a092e6b
@urajat @dorschw
Update Packs/Armorblox/Integrations/Armorblox/Armorblox.yml
1aaffff 
Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
@dorschw
Copy link
Contributor

dorschw commented Dec 6, 2021

Hi, we'd like to move forward and merge it, please address this issue so we can do it.

dorschw
dorschw requested changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@dorschw dorschw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the slack message I sent Rajat for more details

Packs/Armorblox/pack_metadata.json Outdated Show resolved Hide resolved
Packs/Armorblox/Integrations/Armorblox/Armorblox.yml Outdated Show resolved Hide resolved
Packs/Armorblox/Playbooks/Armorblox_Needs_Review_README.md Outdated Show resolved Hide resolved
Packs/Armorblox/Playbooks/Armorblox_Needs_Review_README.md Outdated Show resolved Hide resolved
@demisto demisto deleted a comment from ankita-sharma2019 Dec 6, 2021
dorschw
dorschw approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@dorschw dorschw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@dorschw dorschw merged commit 105b813 into demisto:contrib/armorblox_armorblox Dec 7, 2021
@content-bot content-bot mentioned this pull request Dec 7, 2021
Merged
11 tasks
dorschw added a commit that referenced this pull request Dec 7, 2021
@content-bot @urajat
@ankita-sharma2019 @dorschw
Armorblox Cortex Integration (#16181) (#15873)
b9c7656 
* Armorblox Cortex Integration (#15873)

Co-authored-by: Rajat Upadhyaya <45485+urajat@users.noreply.github.com>
Co-authored-by: Ankita Sharma <ankita.sharma@xoriant.com>
Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
@urajat urajat deleted the armorblox branch July 5, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankita-sharma2019 ankita-sharma2019 ankita-sharma2019 left review comments

@dorschw dorschw dorschw approved these changes

Assignees

@dorschw dorschw

Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Partner post-demo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@urajat @CLAassistant @content-bot @dorschw @ankita-sharma2019