Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armorblox Cortex Integration #16181

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Armorblox Cortex Integration #16181

merged 2 commits into from
Dec 7, 2021

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@urajat

Initial Commit for Cortex Integration
Added README
Deleted www from Armorblox url
Addition of a new command to check remediation actions
Added playbook and changes
Removal of extra space in Armorblox Outbound Threat and renaming MailBox to Mailbox in Armorblox Abuse MailBox Threat
Removed default tenant name
Added changes for testing script
Removed MailBox incident type
Removed unwanted Threat(MailBox and Armorblox Outbound) from mapper
added github users in pack metadata

Co-authored-by: Rajat Upadhyaya 45485+urajat@users.noreply.github.com

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

* Armorblox Cortex Integration

Initial Commit for Cortex Integration
Added README
Deleted www from Armorblox url
Addition of a new command to check remediation actions
Added playbook and changes
Removal of extra space in Armorblox Outbound Threat and renaming MailBox to Mailbox in Armorblox Abuse MailBox Threat
Removed default tenant name
Added changes for testing script
Removed MailBox incident type
Removed unwanted Threat(MailBox and Armorblox  Outbound) from mapper
added github users in pack metadata

Co-authored-by: Rajat Upadhyaya <45485+urajat@users.noreply.github.com>

* Validation-Fix - whitelisted secrets and set unsearchable key to true for all incidentfields (#4)

Co-authored-by: Ankita Sharma <ankita.sharma@xoriant.com>

* added test-cases to increase coverage % to 77

* Review Changes

* Removed unintentional '}'

* Update Packs/Armorblox/Integrations/Armorblox/Armorblox.yml

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>

* Removed custom script to send email.Added mail sender (new) integration in playbook

* Playbook review Changes

* Changed the pack category

Co-authored-by: Ankita Sharma <ankita.sharma@xoriant.com>
Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
@content-bot content-bot added docs-approved Contribution Thank you! Contributions are always welcome! labels Dec 7, 2021
@content-bot content-bot requested a review from dorschw December 7, 2021 06:52
@dorschw dorschw merged commit b9c7656 into master Dec 7, 2021
@dorschw dorschw deleted the contrib/armorblox_armorblox branch December 7, 2021 08:26
@ankita-sharma2019
Copy link
Contributor

ankita-sharma2019 commented Dec 7, 2021

Hello,
By when we can expect this integration to be published in Cortex Marketplace? We see that 1 of the checks failed. Please find more information for the same here. But, cannot find the details for the failed check. Can we know whether any changes are needed? And if yes, please help us with the details.
image

@dorschw
Copy link
Contributor

dorschw commented Dec 7, 2021

Hi @ankita-sharma2019, thanks
The pack should be available on the marketplace within 12-18 hours (looked at it and even though this check failed, it should be fine).

I'll keep an eye on it and make sure it goes live as soon as possible, and update you once it happens.

@ankita-sharma2019
Copy link
Contributor

Hello @dorschw , Thanks for the quick response. Please let us know once the pack goes live. Thanks a lot!

@dorschw
Copy link
Contributor

dorschw commented Dec 7, 2021

congratulations, It's live on the marketplace :)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Thank you! Contributions are always welcome! docs-approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants