Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualys Fetch Vulnerabilities - Include all vulnerabilities on assets #36748

Conversation

johnnywilkes
Copy link
Contributor

@johnnywilkes johnnywilkes commented Oct 15, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • [] In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/EXPANDR-10862

Description

Proposed change is making sure we not only pull Qualys vulnerabilities modified in the last 90 days but also those that are affecting assets that haven’t been modified in the last 90 days. This is to make sure this isn’t a breaking change.
How we do this:

  1. Every time assets are pulled create a list of vulnerabilities (QIDs) we see on them.
  2. Deduplicate this list.
  3. Add the list to getAssetsLastRun()
  4. When we lookup vulnerabilities, first do the call to pull all vulnerabilities modified in last 90 days and create list of these QIDs
  5. Compare list from steps 3 and 4 and deduplicate (create a list of QIDs found on assets that haven’t been modified for last 90 days)
  6. 2nd API call to pull these vulnerabilities that hadn’t been pulled before
  7. Send full list of vulnerabilties to XSIAM

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Oct 15, 2024
@johnnywilkes
Copy link
Contributor Author

@ShirleyDenkberg , please review when possible

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Oct 15, 2024
@content-bot content-bot changed the base branch from master to contrib/PaloAltoNetworks_UVEM-QUALYS October 15, 2024 17:17
@content-bot content-bot requested a review from aaron1535 October 15, 2024 17:17
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @aaron1535 will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @johnnywilkes, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@content-bot
Copy link
Collaborator

Hello,
Thank you for your contribution.
Unfortunately, your PR review will be slightly delayed because of an Israeli holiday in the upcoming two weeks (16-26.10.24). Thank you in advance for the patience.

@ShirleyDenkberg
Copy link
Contributor

@aaron1535 Doc review completed.

Copy link
Contributor

@aaron1535 aaron1535 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @johnnywilkes
Thank you for your contribution.
Nice job!
Please correct my comment and we can merge

Packs/qualys/Integrations/Qualysv2/Qualysv2.py Outdated Show resolved Hide resolved
@johnnywilkes
Copy link
Contributor Author

@aaron1535 , thank you. Merge when possible, please

@aaron1535 aaron1535 merged commit 868c64b into demisto:contrib/PaloAltoNetworks_UVEM-QUALYS Oct 30, 2024
14 checks passed
Copy link

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

@johnnywilkes
Copy link
Contributor Author

@aaron1535 the internal PR #36899 seems to be removed, what are next steps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants