Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualys Fetch Vulnerabilities - Include all vulnerabilities on assets #36899

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@johnnywilkes

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • [] In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/EXPANDR-10862

Description

Proposed change is making sure we not only pull Qualys vulnerabilities modified in the last 90 days but also those that are affecting assets that haven’t been modified in the last 90 days. This is to make sure this isn’t a breaking change.
How we do this:

  1. Every time assets are pulled create a list of vulnerabilities (QIDs) we see on them.
  2. Deduplicate this list.
  3. Add the list to getAssetsLastRun()
  4. When we lookup vulnerabilities, first do the call to pull all vulnerabilities modified in last 90 days and create list of these QIDs
  5. Compare list from steps 3 and 4 and deduplicate (create a list of QIDs found on assets that haven’t been modified for last 90 days)
  6. 2nd API call to pull these vulnerabilities that hadn’t been pulled before
  7. Send full list of vulnerabilties to XSIAM

Must have

  • Tests
  • Documentation

…36748)

* this works

* 90 day vuln plus affected

* cleanup

* formatting

* RN

* Update Packs/qualys/ReleaseNotes/3_0_8.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/qualys/Integrations/Qualysv2/Qualysv2.py

Co-authored-by: azonenfeld <117573492+aaron1535@users.noreply.github.com>

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: azonenfeld <117573492+aaron1535@users.noreply.github.com>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved Contribution Form Filled Whether contribution form filled or not. Community Xsoar Support Level Indicates that the contribution is for XSOAR supported pack Internal PR labels Oct 30, 2024
@content-bot content-bot requested a review from aaron1535 October 30, 2024 08:45
@aaron1535 aaron1535 added the Contribution On Hold Indicates that the contribution is on hold and no work is done on this PR at the moment label Nov 13, 2024
@BigEasyJ
Copy link
Contributor

@aaron1535 Can we please get an update on this on the internal ticket?

@aaron1535 aaron1535 marked this pull request as draft January 9, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution On Hold Indicates that the contribution is on hold and no work is done on this PR at the moment Contribution Thank you! Contributions are always welcome! docs-approved Internal PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants