bug(refs T32855): Fix multiselect #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruenbergerdemos
added
type:bug
| :value="selectedGroups" | ||
| @input="selectGroups"> | ||
| <template v-slot:option="{ option }"> | ||
| <span>{{ option.title }}</span> | ||
| <template v-slot:option="{ props }"> |
There was a problem hiding this comment.
Do we really need to pass in the whole props object here? See question in other PR.
There was a problem hiding this comment.
Yes, because otherwise we can't access the remove function. Or do you have an idea about that?
There was a problem hiding this comment.
no, not at the first glance.
hwiem
requested changes
May 24, 2023
client/js/components/statement/assessmentTable/AssignEntityModal.vue
Outdated
Show resolved
Hide resolved
client/js/components/statement/statement/SelectStatementCluster.vue
Outdated
Show resolved
Hide resolved
| :value="currentUserOrga" | ||
| :searchable="true" | ||
| :id="userId + ':organisationId'" | ||
| :close-on-select="true" |
There was a problem hiding this comment.
Where is closeOnSelect used?
There was a problem hiding this comment.
It is used in the vue multiselect. I added a prop in DpMultiselect (default true). 24fc29a
…al.vue Co-authored-by: hwiem <40487668+hwiem@users.noreply.github.com>
…r.vue Co-authored-by: hwiem <40487668+hwiem@users.noreply.github.com>
Default for searchable is true.
Default for closeOnSelect is true.
gruenbergerdemos
added
the
lifecycle:do-not-merge
spiess-demos
approved these changes
May 24, 2023
spiess-demos
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://yaits.demos-deutschland.de/T32855
DpMultiselect was changed from a functional component to a template-component, because functional components won't work in vue3.
We also need to adjust the slot props here, because we now have an additional child that passes on the props.
How to review/test
Check some multiselects (eg. Verfahren -> Grundeinstellungen -> Datenerfassende Organisation).
Linked PRs (optional)
demos-europe/demosplan-ui#237