-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(refs T3285): Fix multiselect #237
Conversation
… true Also add button text.
@@ -26,31 +31,37 @@ | |||
</template> | |||
|
|||
<template v-slot:option="props"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also just expose option in the slots? Then, we would not have to adapt all useages.
<template v-slot:option="props"> | |
<template v-slot:option="{ option }"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this, but then I couldn't access the remove function and it did not work (@click="props.remove(props.option)"
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (code review)
Ticket: https://yaits.demos-deutschland.de/T32855