Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(refs T3285): Fix multiselect #237

Merged
merged 9 commits into from
May 24, 2023
Merged

Conversation

gruenbergerdemos
Copy link
Contributor

@gruenbergerdemos gruenbergerdemos commented May 23, 2023

Ticket: https://yaits.demos-deutschland.de/T32855

  • Add more types for prop value
  • Bind props to slot, so they are available for parent
  • Show selection buttons only if prop for controls is true
  • Add all event listener

@gruenbergerdemos gruenbergerdemos self-assigned this May 23, 2023
@gruenbergerdemos gruenbergerdemos added bug Something isn't working review:frontend labels May 23, 2023
@gruenbergerdemos gruenbergerdemos marked this pull request as ready for review May 23, 2023 08:02
@gruenbergerdemos gruenbergerdemos marked this pull request as draft May 23, 2023 09:11
@gruenbergerdemos gruenbergerdemos marked this pull request as ready for review May 23, 2023 13:27
@@ -26,31 +31,37 @@
</template>

<template v-slot:option="props">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also just expose option in the slots? Then, we would not have to adapt all useages.

Suggested change
<template v-slot:option="props">
<template v-slot:option="{ option }">

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this, but then I couldn't access the remove function and it did not work (@click="props.remove(props.option)".

Copy link
Contributor

@spiess-demos spiess-demos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (code review)

@gruenbergerdemos gruenbergerdemos merged commit a5afd22 into main May 24, 2023
@gruenbergerdemos gruenbergerdemos deleted the b_T32855_multiselect_types branch May 24, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working review:frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants