chore: use default chunkSize value (Infinity) for tus uploads #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakutademos
approved these changes
Oct 2, 2024
hwiem
approved these changes
Oct 2, 2024
- Important: Only change the default value if you are very sure about the consequences. It is recommended to change the value via setting the chunkSize prop instead of adjusting the default here, which basically allows the upload chunks to be as big as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR removes the file upload max chunkSize from the DpUpload component and uses now the default value of the prop which resolves to
Infinity. This change is for the demosplan vue3 compatible version.The same change for the vue2 compatible version can be found here: #1032