fix(ext/websocket): do not continue reading if socket rid closes (#21849

) Fixes #21379
denoland · Mar 14, 2024 · 010272a · 010272a
1 parent 4419fc3
commit 010272a
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 8 deletions.
diff --git a/ext/websocket/01_websocket.js b/ext/websocket/01_websocket.js
@@ -417,9 +417,14 @@ class WebSocket extends EventTarget {
       switch (kind) {
         case 0: {
           /* string */
+          const data = op_ws_get_buffer_as_string(rid);
+          if (data === undefined) {
+            break;
+          }
+
           this[_serverHandleIdleTimeout]();
           const event = new MessageEvent("message", {
-            data: op_ws_get_buffer_as_string(rid),
+            data,
             origin: this[_url],
           });
           setIsTrusted(event, true);
@@ -428,9 +433,14 @@ class WebSocket extends EventTarget {
         }
         case 1: {
           /* binary */
+          const d = op_ws_get_buffer(rid);
+          if (d == undefined) {
+            break;
+          }
+
           this[_serverHandleIdleTimeout]();
           // deno-lint-ignore prefer-primordials
-          const buffer = op_ws_get_buffer(rid).buffer;
+          const buffer = d.buffer;
           let data;
           if (this.binaryType === "blob") {
             data = new Blob([buffer]);

diff --git a/ext/websocket/lib.rs b/ext/websocket/lib.rs
@@ -703,19 +703,23 @@ pub async fn op_ws_close(
 pub fn op_ws_get_buffer(
   state: &mut OpState,
   #[smi] rid: ResourceId,
-) -> Result<ToJsBuffer, AnyError> {
-  let resource = state.resource_table.get::<ServerWebSocket>(rid)?;
-  Ok(resource.buffer.take().unwrap().into())
+) -> Option<ToJsBuffer> {
+  let Ok(resource) = state.resource_table.get::<ServerWebSocket>(rid) else {
+    return None;
+  };
+  resource.buffer.take().map(ToJsBuffer::from)
 }
 
 #[op2]
 #[string]
 pub fn op_ws_get_buffer_as_string(
   state: &mut OpState,
   #[smi] rid: ResourceId,
-) -> Result<String, AnyError> {
-  let resource = state.resource_table.get::<ServerWebSocket>(rid)?;
-  Ok(resource.string.take().unwrap())
+) -> Option<String> {
+  let Ok(resource) = state.resource_table.get::<ServerWebSocket>(rid) else {
+    return None;
+  };
+  resource.string.take()
 }
 
 #[op2]