Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/websocket): do not continue reading if socket rid closes #21849

Merged
merged 4 commits into from
Mar 9, 2024
Merged

fix(ext/websocket): do not continue reading if socket rid closes #21849

merged 4 commits into from
Mar 9, 2024

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Jan 8, 2024 •
edited
Loading

Fixes #21379

@littledivy littledivy requested a review from mmastrac January 8, 2024 12:44
bartlomieju
bartlomieju reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for this change? Let's say a server forcefully closes the connection after exchanging 3 messages.

@benStre benStre mentioned this pull request Feb 13, 2024
Merged
bartlomieju
bartlomieju approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Discussed offline, we have no way to create a precise unit test for it, because we'd need to expose these ops to the user code (which we don't want to do).

@littledivy littledivy merged commit e1fb174 into denoland:main Mar 9, 2024
17 checks passed
nathanwhit pushed a commit that referenced this pull request Mar 14, 2024
@littledivy @nathanwhit
fix(ext/websocket): do not continue reading if socket rid closes (#21849
010272a 
)

Fixes #21379
@jasonford jasonford mentioned this pull request May 7, 2024
Closed
@benStre benStre mentioned this pull request Jun 7, 2024
Merged
@lucacasonato lucacasonato mentioned this pull request Jun 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@mmastrac mmastrac Awaiting requested review from mmastrac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fresh Web Server dies with "Bad resource ID" in Dev Mode
2 participants
@littledivy @bartlomieju