Support Parcel #20613

birkskyum · 2023-09-21T13:09:34Z

Platform

Darwin 22.6.0 arm64 arm

Version

deno 1.37.0

Repro

Make an index.html

<html>
  <head>
    <title>My First Parcel App</title>
  </head>
  <body>
    <h1>Hello, World!</h1>
  </body>
</html>

Run it with deno

deno run -A npm:parcel index.html

Expected

Server running at http://localhost:1234
✨ Built in 494ms

Actual

➜ deno run -A npm:parcel index.html
Error: Not implemented: v8.deserialize
    at notImplemented (ext:deno_node/_utils.ts:9:9)
    at deserialize (node:v8:62:3)
    at deserialize (file:///Users/admin/repos/deno-parcel/node_modules/.deno/@parcel+core@2.9.3/node_modules/@parcel/core/lib/serializer.js:204:48)
    at loadRequestGraph (file:///Users/admin/repos/deno-parcel/node_modules/.deno/@parcel+core@2.9.3/node_modules/@parcel/core/lib/RequestTracker.js:744:52)
    at eventLoopTick (ext:core/01_core.js:183:11)
    at async Function.init (file:///Users/admin/repos/deno-parcel/node_modules/.deno/@parcel+core@2.9.3/node_modules/@parcel/core/lib/RequestTracker.js:718:17)
    at async Parcel._init (file:///Users/admin/repos/deno-parcel/node_modules/.deno/@parcel+core@2.9.3/node_modules/@parcel/core/lib/Parcel.js:178:28)
    at async Parcel.watch (file:///Users/admin/repos/deno-parcel/node_modules/.deno/@parcel+core@2.9.3/node_modules/@parcel/core/lib/Parcel.js:228:7)
    at async run (file:///Users/admin/repos/deno-parcel/node_modules/.deno/parcel@2.9.3/node_modules/parcel/lib/cli.js:286:9)
error: Uncaught (in worker "$DENO_STD_NODE_WORKER_THREAD") (in promise) Error: Only create ThreadsChild instances in a worker!
    at new ThreadsChild (file:///Users/admin/repos/deno-parcel/node_modules/.deno/@parcel+workers@2.9.3/node_modules/@parcel/workers/lib/threads/ThreadsChild.js:34:13)
    at new Child (file:///Users/admin/repos/deno-parcel/node_modules/.deno/@parcel+workers@2.9.3/node_modules/@parcel/workers/lib/child.js:65:18)
    at Object.<anonymous> (file:///Users/admin/repos/deno-parcel/node_modules/.deno/@parcel+workers@2.9.3/node_modules/@parcel/workers/lib/threads/ThreadsChild.js:49:27)
    at Object.<anonymous> (file:///Users/admin/repos/deno-parcel/node_modules/.deno/@parcel+workers@2.9.3/node_modules/@parcel/workers/lib/threads/ThreadsChild.js:50:4)
    at Module._compile (node:module:733:34)
    at Object.Module._extensions..js (node:module:747:10)
    at Module.load (node:module:658:32)
    at Function.Module._load (node:module:539:12)
    at Module.require (node:module:677:19)
    at require (node:module:791:16)

The text was updated successfully, but these errors were encountered:

bartlomieju · 2023-09-28T20:30:07Z

@birkskyum thanks for reporting. I can't seem to reproduce the problem you are facing, for me parcel is failing on resolution of some modules:

Error: Cannot find module '@parcel/config-default'
Require stack:
- /Users/ib/Library/Caches/deno/npm/registry.npmjs.org/parcel/2.9.3/lib/cli.js
- /Users/ib/Library/Caches/deno/npm/registry.npmjs.org/parcel/2.9.3/lib/bin.js
    at Function.Module._resolveFilename (node:module:624:15)
    at Function.resolve (node:module:794:19)
    at run (file:///Users/ib/Library/Caches/deno/npm/registry.npmjs.org/parcel/2.9.3/lib/cli.js:217:28)
    at eventLoopTick (ext:core/01_core.js:197:13) {
  code: "MODULE_NOT_FOUND",
  requireStack: [
    "/Users/ib/Library/Caches/deno/npm/registry.npmjs.org/parcel/2.9.3/lib/cli.js",
    "/Users/ib/Library/Caches/deno/npm/registry.npmjs.org/parcel/2.9.3/lib/bin.js"
  ]
}

And if I use --node-modules-dir flag I get:

error: Uncaught (in worker "$DENO_STD_NODE_WORKER_THREAD") (in promise) Error: Only create ThreadsChild instances in a worker!
    at new ThreadsChild (file:///Users/ib/dev/try_parcel/node_modules/.deno/@parcel+workers@2.9.3/node_modules/@parcel/workers/lib/threads/ThreadsChild.js:34:13)
    at new Child (file:///Users/ib/dev/try_parcel/node_modules/.deno/@parcel+workers@2.9.3/node_modules/@parcel/workers/lib/child.js:65:18)
    at Object.<anonymous> (file:///Users/ib/dev/try_parcel/node_modules/.deno/@parcel+workers@2.9.3/node_modules/@parcel/workers/lib/threads/ThreadsChild.js:49:27)
    at Object.<anonymous> (file:///Users/ib/dev/try_parcel/node_modules/.deno/@parcel+workers@2.9.3/node_modules/@parcel/workers/lib/threads/ThreadsChild.js:50:4)
    at Module._compile (node:module:733:34)
    at Object.Module._extensions..js (node:module:747:10)
    at Module.load (node:module:658:32)
    at Function.Module._load (node:module:539:12)
    at Module.require (node:module:677:19)
    at require (node:module:791:16)
// more errors like this

(what I mean is that I can't hit that v8.deserialize error, the error coming from workers is legit one and I know how to fix it)

birkskyum · 2023-09-28T20:41:20Z

I tried updating to deno 1.37.1, and run again, and now I see the same output as you.

This addresses #20613 (comment).

bartlomieju · 2024-03-24T06:11:11Z

@birkskyum any chance you could try again with latest canary? We put a lot of effort into improving node:worker_threads module recently and I think this might now work correctly.

birkskyum · 2024-03-24T11:00:24Z

Fantastic work on pushing the compat! I get this now, so it could be it's very close for both Expo and Parcel:

➜ deno run -A npm:parcel index.html
TypeError: Cannot read properties of undefined (reading 'Symbol(Deno.internal.rid)')
    at TTY.#read (ext:deno_node/internal_binding/stream_wrap.ts:220:45)
    at TTY.readStart (ext:deno_node/internal_binding/stream_wrap.ts:90:17)
    at _tryReadStart (node:net:276:30)
    at ReadStream._read (node:net:856:7)
    at ReadStream.Readable.read (ext:deno_node/_stream.mjs:2999:16)
    at ReadStream.read (node:net:789:34)
    at resume_ (ext:deno_node/_stream.mjs:3349:16)
    at Array.processTicksAndRejections (ext:deno_node/_next_tick.ts:33:15)
    at eventLoopTick (ext:core/01_core.js:165:29)

birkskyum · 2024-03-30T01:49:09Z

Running with canary now gives this:

(base) birkskyum@Birks-MacBook-Pro deno-kitchensink % deno run -A npm:parcel index.html
Error: Cannot find module '@parcel/config-default'
Require stack:
- /Users/birkskyum/Library/Caches/deno/npm/registry.npmjs.org/parcel/2.12.0/lib/cli.js
- /Users/birkskyum/Library/Caches/deno/npm/registry.npmjs.org/parcel/2.12.0/lib/bin.js
    at Function.Module._resolveFilename (node:module:609:15)
    at Function.resolve (node:module:779:19)
    at run (file:///Users/birkskyum/Library/Caches/deno/npm/registry.npmjs.org/parcel/2.12.0/lib/cli.js:217:28)
    at eventLoopTick (ext:core/01_core.js:207:9) {
  code: "MODULE_NOT_FOUND",
  requireStack: [
    "/Users/birkskyum/Library/Caches/deno/npm/registry.npmjs.org/parcel/2.12.0/lib/cli.js",
    "/Users/birkskyum/Library/Caches/deno/npm/registry.npmjs.org/parcel/2.12.0/lib/bin.js"
  ]

I figured I'd try installing parcel with npm and try running it as a "script" in package json, with and without the byonm flag in deno.js, but then I hit this, and the terminal froze completely, to the point where I could not even abort it.

Task compress parcel index.html

deno run npm:<package> with same compat as DENO_FUTURE=1/BYONM #24903

zzz6519003 · 2024-04-09T07:22:15Z

deno deploy + parcel template pls

…#25243) Fixes #23281. Part of #20613. We were emitting the `online` event in the constructor, so the caller could never receive it (since there was no time for them to add a listener). Instead, emit the event where it's intended – after the worker is initialized. --- After this parcel no longer freezes, but still will fail due to other bugs (which will be fixed in other PRs)

…5245) Part of #20613. If a node addon is using the legacy `napi_module_register` on ctor approach to module registration, we have to store the registered module so that other threads can load the addon (because `napi_module_register` will only be called once per process).

…#25243) Fixes #23281. Part of #20613. We were emitting the `online` event in the constructor, so the caller could never receive it (since there was no time for them to add a listener). Instead, emit the event where it's intended – after the worker is initialized. --- After this parcel no longer freezes, but still will fail due to other bugs (which will be fixed in other PRs)

…5245) Part of #20613. If a node addon is using the legacy `napi_module_register` on ctor approach to module registration, we have to store the registered module so that other threads can load the addon (because `napi_module_register` will only be called once per process).

bartlomieju added bug Something isn't working correctly node compat labels Sep 22, 2023

bartlomieju self-assigned this Sep 26, 2023

This was referenced Oct 4, 2023

Support deno parcel-bundler/parcel#7108

Open

fix(ext/node): worker_threads.parentPort is updated on startup #20794

Merged

bartlomieju mentioned this issue Feb 8, 2024

Node.js compat roadmap February 2024 #22337

Closed

20 tasks

bartlomieju added a commit that referenced this issue Mar 11, 2024

fix(ext/node): worker_threads.parentPort is updated on startup (#20794)

bb6e4c7

This addresses #20613 (comment).

nathanwhit pushed a commit that referenced this issue Mar 14, 2024

fix(ext/node): worker_threads.parentPort is updated on startup (#20794)

6263bcb

This addresses #20613 (comment).

bartlomieju added the node API polyfill Related to various "node:*" modules APIs label Mar 31, 2024

bartlomieju removed their assignment Mar 31, 2024

nathanwhit self-assigned this Aug 28, 2024

This was referenced Aug 28, 2024

fix(ext/node): emit online event after worker thread is initialized #25243

Merged

fix(napi): Fix worker threads importing already-loaded NAPI addon #25245

Merged

nathanwhit mentioned this issue Sep 5, 2024

fix(ext/node): Rewrite node:v8 serialize/deserialize #25439

Merged

nathanwhit closed this as completed in #25439 Sep 10, 2024

nathanwhit closed this as completed in be0ba6d Sep 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Parcel #20613

Support Parcel #20613

birkskyum commented Sep 21, 2023

bartlomieju commented Sep 28, 2023 •

edited

Loading

birkskyum commented Sep 28, 2023 •

edited

Loading

bartlomieju commented Mar 24, 2024

birkskyum commented Mar 24, 2024 •

edited

Loading

birkskyum commented Mar 30, 2024 •

edited

Loading

zzz6519003 commented Apr 9, 2024

Support Parcel #20613

Support Parcel #20613

Comments

birkskyum commented Sep 21, 2023

bartlomieju commented Sep 28, 2023 • edited Loading

birkskyum commented Sep 28, 2023 • edited Loading

bartlomieju commented Mar 24, 2024

birkskyum commented Mar 24, 2024 • edited Loading

birkskyum commented Mar 30, 2024 • edited Loading

zzz6519003 commented Apr 9, 2024

bartlomieju commented Sep 28, 2023 •

edited

Loading

birkskyum commented Sep 28, 2023 •

edited

Loading

birkskyum commented Mar 24, 2024 •

edited

Loading

birkskyum commented Mar 30, 2024 •

edited

Loading