-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ext/node): use tty stdin from ext/io #23044
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small test would be great!
I'm not sure how to trigger the bug. This test is passing on import * as process from 'node:process';
const { stdin } = process;
stdin.setRawMode(true);
stdin.resume();
stdin.setEncoding('utf8');
stdin.on('data', (key) => {
if (key === '\u0003') {
// Ctrl+C
process.exit();
}
process.stdout.write(key);
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Divy added a smoke test in a separate repo
This is the same issue as denoland#23044 but in `WriteStream`. Adding a docusarus test in npm_smoke_tests repo
This is the same issue as #23044 but in `WriteStream`. Adding a docusarus test in npm_smoke_tests repo.
This is the same issue as #23044 but in `WriteStream`. Adding a docusarus test in npm_smoke_tests repo.
This is the same issue as denoland#23044 but in `WriteStream`. Adding a docusarus test in npm_smoke_tests repo.
Fixes #23043 #23107