Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): use ext/io stdio in WriteStream #23354

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

littledivy
Copy link
Member

This is the same issue as #23044 but in WriteStream.

Adding a docusarus test in npm_smoke_tests repo.

This is the same issue as denoland#23044
but in `WriteStream`.

Adding a docusarus test in npm_smoke_tests repo
Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit 1fadb94 into denoland:main Apr 13, 2024
17 checks passed
@littledivy littledivy deleted the node_tty_io branch April 13, 2024 15:55
bartlomieju pushed a commit that referenced this pull request Apr 15, 2024
This is the same issue as #23044
but in `WriteStream`.

Adding a docusarus test in npm_smoke_tests repo.
littledivy added a commit to littledivy/deno that referenced this pull request Apr 19, 2024
This is the same issue as denoland#23044
but in `WriteStream`.

Adding a docusarus test in npm_smoke_tests repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants