Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storybook: init new project with storybook, deno fails to run it #26404

Open
birkskyum opened this issue Oct 18, 2024 · 1 comment
Open

storybook: init new project with storybook, deno fails to run it #26404

birkskyum opened this issue Oct 18, 2024 · 1 comment
Assignees
@nathanwhit
Labels
bug Something isn't working correctly node compat

Comments

@birkskyum
Copy link
Contributor

birkskyum commented Oct 18, 2024 •
edited
Loading

deno 2.0.2

Repro:

  • deno run -A npm:storybook@latest init or npx storybook@latest init (select vue 3 + vite)
  • deno task storybook

Error:

➜ deno task storybook
Task storybook storybook dev -p 6006
@storybook/core v8.3.6

NotFound: No such file or directory (os error 2): readfile 'chromatic.config.json'
    at Object.readFileSync (ext:deno_fs/30_fs.js:733:10)
    at Object.readFileSync (ext:deno_node/_fs/_fs_readFile.ts:52:21)
    at Object.Ege (file://./node_modules/.deno/chromatic@11.12.6/node_modules/chromatic/dist/chunk-P6VYOOE6.js:827:1175)
    at Object.Uir [as experimental_serverChannel] (file://./node_modules/.deno/@chromatic-com+storybook@1.9.0/node_modules/@chromatic-com/storybook/dist/preset.js:595:402)
    at file://./node_modules/.deno/@storybook+core@8.3.6/node_modules/@storybook/core/dist/common/index.cjs:139480:18
    at eventLoopTick (ext:core/01_core.js:175:7)
    at async storybookDevServer (file://./node_modules/.deno/@storybook+core@8.3.6/node_modules/@storybook/core/dist/core-server/index.cjs:47285:11)
    at async buildOrThrow (file://./node_modules/.deno/@storybook+core@8.3.6/node_modules/@storybook/core/dist/core-server/index.cjs:46581:12)
    at async buildDevStandalone (file://./node_modules/.deno/@storybook+core@8.3.6/node_modules/@storybook/core/dist/core-server/index.cjs:48518:78)
    at async withTelemetry (file://./node_modules/.deno/@storybook+core@8.3.6/node_modules/@storybook/core/dist/core-server/index.cjs:47080:12)
@birkskyum birkskyum mentioned this issue Oct 18, 2024
Open
@birkskyum birkskyum changed the title storybook: init without existing folder storybook: init and run project, without existing folder Oct 18, 2024
@birkskyum birkskyum changed the title storybook: init and run project, without existing folder storybook: init and run, without existing project Oct 18, 2024
@birkskyum birkskyum changed the title storybook: init and run, without existing project storybook: init new project with storybook, deno fails to run it Oct 18, 2024
@littledivy littledivy added bug Something isn't working correctly node compat labels Oct 19, 2024
@nathanwhit nathanwhit self-assigned this Oct 26, 2024
This was referenced Oct 29, 2024
Open
Merged
nathanwhit added a commit that referenced this issue Oct 31, 2024
@nathanwhit
fix(ext/node): convert errors from fs.readFile/fs.readFileSync to n…
951103f 
…ode format (#26632)

Fixes the original issue reported in #26404. storybook runs into other
errors after this PR (the new errors will be fixed in other PRs).

Some code used by a dependency of storybook does a [string comparison on
the error
message](https://github.com/chromaui/chromatic-cli/blob/ce30b2be343cb96a0826390b95ea42befb2be547/node-src/lib/getConfiguration.ts#L88-L92)
thrown here to check for a file not found error.
bartlomieju pushed a commit that referenced this issue Nov 5, 2024
@nathanwhit @bartlomieju
fix(ext/node): convert errors from fs.readFile/fs.readFileSync to n…
d284d1c 
…ode format (#26632)

Fixes the original issue reported in #26404. storybook runs into other
errors after this PR (the new errors will be fixed in other PRs).

Some code used by a dependency of storybook does a [string comparison on
the error
message](https://github.com/chromaui/chromatic-cli/blob/ce30b2be343cb96a0826390b95ea42befb2be547/node-src/lib/getConfiguration.ts#L88-L92)
thrown here to check for a file not found error.
@kfp
Copy link

kfp commented Nov 22, 2024 •
edited
Loading

With deno v2.1.1 (react+vite):

$ deno task storybook
Task storybook storybook dev -p 6006
@storybook/core v8.4.5

TypeError: g.start is not a function
    at storybookDevServer (file://./node_modules/@storybook/core/dist/core-server/index.cjs:35974:19)
    at eventLoopTick (ext:core/01_core.js:175:7)
    at async buildOrThrow (file://./node_modules/@storybook/core/dist/core-server/index.cjs:35017:12)
    at async buildDevStandalone (file://./node_modules/@storybook/core/dist/core-server/index.cjs:37190:78)
    at async withTelemetry (file://./node_modules/@storybook/core/dist/core-server/index.cjs:35757:12)
    at async dev (file://./node_modules/@storybook/core/dist/cli/bin/index.cjs:2591:3)
    at async s.<anonymous> (file://./node_modules/@storybook/core/dist/cli/bin/index.cjs:2643:74)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanwhit nathanwhit

Labels
bug Something isn't working correctly node compat
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kfp @nathanwhit @littledivy @birkskyum