fix(ext/node): attach error code when require fails on package exports #26631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwhit
force-pushed
the
require-exports-error-code
branch
from
c3b690b to
d6e3c65
Compare
bartlomieju
reviewed
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #26404
storybook relies on the
codeproperty being set onERR_PACKAGE_PATH_NOT_EXPORTEDerrors (they useresolveto locate files, and just ignoreERR_PACKAGE_PATH_NOT_EXPORTEDerrors). As the todo comment says, ideally we would just attach thecodeproperty on the rust side, but we lack the infrastructure for this currently. We already format the error message with the code at the beginning[ERR_PACKAGE_PATH_NOT_EXPORTED] ..., so as a quick and dirty solution just extract this and attach thecodeproperty to the error object.