Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deno install errors on JSON export from jsr package #26509

Closed
nathanwhit opened this issue Oct 24, 2024 · 0 comments · Fixed by #26552
Closed

deno install errors on JSON export from jsr package #26509

nathanwhit opened this issue Oct 24, 2024 · 0 comments · Fixed by #26552
Assignees
@nathanwhit
Labels
bug Something isn't working correctly install

Comments

@nathanwhit
Copy link
Member 

          @nathanwhit It seems that now deno install fails with:

rm -rf ~/.cache/deno && ~/repos/deno/target/debug/deno install
error: Expected a JavaScript or TypeScript module, but identified a Json module. Consider importing Json modules with an import attribute with the type of "json".
  Specifier: https://jsr.io/@std/html/1.0.3/named_entity_list.json

I am not importing the file directly in my code, so i assume this is something breaking on the install process, where it does not properly handle json exports?

Originally posted by @M4RC3L05 in #26180 (comment)
@nathanwhit nathanwhit mentioned this issue Oct 24, 2024
Closed
@lucacasonato lucacasonato added bug Something isn't working correctly install labels Oct 24, 2024
@nathanwhit nathanwhit self-assigned this Oct 24, 2024
@nathanwhit nathanwhit mentioned this issue Oct 24, 2024
Merged
bartlomieju pushed a commit that referenced this issue Oct 24, 2024
@nathanwhit
fix(install): don't cache json exports of JSR packages (for now) (#26530
0060e74 
)

Temporary fix for #26509, so people don't get errors.
bartlomieju pushed a commit that referenced this issue Oct 25, 2024
@nathanwhit @bartlomieju
fix(install): don't cache json exports of JSR packages (for now) (#26530
eba48ac 
)

Temporary fix for #26509, so people don't get errors.
This was referenced Oct 25, 2024
Merged
Merged
nathanwhit added a commit that referenced this issue Oct 25, 2024
@nathanwhit
fix(install): cache json exports of JSR packages (#26552)
ec968aa 
Fixes #26509.

Ended up being a `deno_graph` bug causing the error to surface. This PR
updates `deno_graph` to pick up the fix and reverts the temporary
workaround that skipped JSON exports.
bartlomieju pushed a commit that referenced this issue Oct 29, 2024
@nathanwhit @bartlomieju
fix(install): cache json exports of JSR packages (#26552)
f9e70c0 
Fixes #26509.

Ended up being a `deno_graph` bug causing the error to surface. This PR
updates `deno_graph` to pick up the fix and reverts the temporary
workaround that skipped JSON exports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanwhit nathanwhit

Labels
bug Something isn't working correctly install
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(install): cache json exports of JSR packages nathanwhit/deno
2 participants
@lucacasonato @nathanwhit