Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): cache json exports of JSR packages #26552

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

nathanwhit
Copy link
Member

Fixes #26509.

Ended up being a deno_graph bug causing the error to surface. This PR updates deno_graph to pick up the fix and reverts the temporary workaround that skipped JSON exports.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nathanwhit nathanwhit enabled auto-merge (squash) October 25, 2024 20:18
@nathanwhit nathanwhit merged commit ec968aa into denoland:main Oct 25, 2024
17 checks passed
@nathanwhit nathanwhit deleted the install-json branch October 25, 2024 20:20
bartlomieju pushed a commit that referenced this pull request Oct 29, 2024
Fixes #26509.

Ended up being a `deno_graph` bug causing the error to surface. This PR
updates `deno_graph` to pick up the fix and reverts the temporary
workaround that skipped JSON exports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno install errors on JSON export from jsr package
2 participants