Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip comments from inlined assets #486

Closed
kitsonk opened this issue Aug 8, 2018 · 6 comments
Closed

Strip comments from inlined assets #486

kitsonk opened this issue Aug 8, 2018 · 6 comments

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Aug 8, 2018

The inlined .d.ts files contain a lot of JSDoc comments that enrich the IDE experience but are totally useless in the runtime. These should be stripped out during the build process. I have an idea on how to do this.

@ry
Copy link
Member

ry commented Aug 8, 2018

Yeah - sounds good

@Pato91
Copy link

Pato91 commented Aug 9, 2018

A while back I was looking into that and I also do not know how to do it but there was an interesting conversation that caught my eye in the TypesScript issues particulary issue 2,705 that seem to suggest that we either have the JSDoc comments or not but all in all it seems that we disable this within the TypeScript compiler by enabling the

removeComments
compile option in the tsconfig.js file

But all in all, there are interesting conversations going about on this within the typescript issues panel.

@kitsonk
Copy link
Contributor Author

kitsonk commented Aug 9, 2018

The challenge is that these are not transpiled files, they are existing declaration files, so they need to be passed and their "triva" removed.

@bartlomieju
Copy link
Member

@kitsonk is this issue still relevant?

@kitsonk
Copy link
Contributor Author

kitsonk commented Feb 12, 2019

Still relevant, just my initial attempt didn't go so well. It extra binary weight we don't need.

@kitsonk
Copy link
Contributor Author

kitsonk commented Jun 9, 2019

It isn't straight forward and I think we can worry about it some other time.

@kitsonk kitsonk closed this as completed Jun 9, 2019
piscisaureus pushed a commit to piscisaureus/deno that referenced this issue Oct 7, 2019
hardfist pushed a commit to hardfist/deno that referenced this issue Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants