Skip to content

Commit

Permalink
use unknown instead of any (denoland#486)
Browse files Browse the repository at this point in the history
  • Loading branch information
clarkdo authored and ry committed Jun 6, 2019
1 parent 2292fbe commit c64734c
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 28 deletions.
2 changes: 1 addition & 1 deletion flags/mod.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export interface ArgParsingOptions {
boolean?: boolean | string | string[];
alias?: { [key: string]: string | string[] };
string?: string | string[];
default?: { [key: string]: unknown }; // eslint-disable-line @typescript-eslint/no-explicit-any
default?: { [key: string]: unknown };
"--"?: boolean;
stopEarly?: boolean;
}
Expand Down
22 changes: 7 additions & 15 deletions log/logger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ import { BaseHandler } from "./handlers.ts";

export interface LogRecord {
msg: string;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
args: any[];
args: unknown[];
datetime: Date;
level: number;
levelName: string;
Expand All @@ -24,8 +23,7 @@ export class Logger {
this.handlers = handlers || [];
}

// eslint-disable-next-line @typescript-eslint/no-explicit-any
_log(level: number, msg: string, ...args: any[]): void {
_log(level: number, msg: string, ...args: unknown[]): void {
if (this.level > level) return;

// TODO: it'd be a good idea to make it immutable, so
Expand All @@ -38,36 +36,30 @@ export class Logger {
level: level,
levelName: getLevelName(level)
};

this.handlers.forEach(
(handler): void => {
handler.handle(record);
}
);
}

// eslint-disable-next-line @typescript-eslint/no-explicit-any
debug(msg: string, ...args: any[]): void {
debug(msg: string, ...args: unknown[]): void {
this._log(LogLevel.DEBUG, msg, ...args);
}

// eslint-disable-next-line @typescript-eslint/no-explicit-any
info(msg: string, ...args: any[]): void {
info(msg: string, ...args: unknown[]): void {
this._log(LogLevel.INFO, msg, ...args);
}

// eslint-disable-next-line @typescript-eslint/no-explicit-any
warning(msg: string, ...args: any[]): void {
warning(msg: string, ...args: unknown[]): void {
this._log(LogLevel.WARNING, msg, ...args);
}

// eslint-disable-next-line @typescript-eslint/no-explicit-any
error(msg: string, ...args: any[]): void {
error(msg: string, ...args: unknown[]): void {
this._log(LogLevel.ERROR, msg, ...args);
}

// eslint-disable-next-line @typescript-eslint/no-explicit-any
critical(msg: string, ...args: any[]): void {
critical(msg: string, ...args: unknown[]): void {
this._log(LogLevel.CRITICAL, msg, ...args);
}
}
15 changes: 5 additions & 10 deletions log/mod.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,20 +62,15 @@ export function getLogger(name?: string): Logger {
return state.loggers.get(name)!;
}

// eslint-disable-next-line @typescript-eslint/no-explicit-any
export const debug = (msg: string, ...args: any[]): void =>
export const debug = (msg: string, ...args: unknown[]): void =>
getLogger("default").debug(msg, ...args);
// eslint-disable-next-line @typescript-eslint/no-explicit-any
export const info = (msg: string, ...args: any[]): void =>
export const info = (msg: string, ...args: unknown[]): void =>
getLogger("default").info(msg, ...args);
// eslint-disable-next-line @typescript-eslint/no-explicit-any
export const warning = (msg: string, ...args: any[]): void =>
export const warning = (msg: string, ...args: unknown[]): void =>
getLogger("default").warning(msg, ...args);
// eslint-disable-next-line @typescript-eslint/no-explicit-any
export const error = (msg: string, ...args: any[]): void =>
export const error = (msg: string, ...args: unknown[]): void =>
getLogger("default").error(msg, ...args);
// eslint-disable-next-line @typescript-eslint/no-explicit-any
export const critical = (msg: string, ...args: any[]): void =>
export const critical = (msg: string, ...args: unknown[]): void =>
getLogger("default").critical(msg, ...args);

export async function setup(config: LogConfig): Promise<void> {
Expand Down
5 changes: 3 additions & 2 deletions log/test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@ class TestHandler extends log.handlers.BaseHandler {
}

test(async function defaultHandlers(): Promise<void> {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
const loggers: { [key: string]: (msg: string, ...args: any[]) => void } = {
const loggers: {
[key: string]: (msg: string, ...args: unknown[]) => void;
} = {
DEBUG: log.debug,
INFO: log.info,
WARNING: log.warning,
Expand Down

0 comments on commit c64734c

Please sign in to comment.