Organize dispatch a bit #2796
Merged
Organize dispatch a bit #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
force-pushed
the
dispatch_flatbuffers
branch
2 times, most recently
from
0621bc8
to
bdd5995
Compare
bartlomieju
reviewed
Aug 21, 2019
ry
force-pushed
the
dispatch_flatbuffers
branch
from
2e1f598
to
4299dc5
Compare
ry
force-pushed
the
dispatch_flatbuffers
branch
from
19facab
to
8a24b9c
Compare
Just some clean up reorganization around flatbuffer/minimal dispatch code. This is prep for adding a JSON dispatcher.
ry
force-pushed
the
dispatch_flatbuffers
branch
from
b1af552
to
d46ddb1
Compare
piscisaureus
approved these changes
Aug 21, 2019
|
This patch caused the compiler.js bundle to increase from 7.8 MB to 9.1 MB, which ultimately resulted in adding 2.5 MB to the final executable. This is bad and unexpected.
That said I don't want to revert it because it is preliminary work necessary for ultimately removing flatbuffers - which I think will have a very positive impact on the bundles and executable size. |
ry
commented
Aug 22, 2019
| import * as msg from "gen/cli/msg_generated"; | ||
| import * as util from "./util"; | ||
| import { OP_FLATBUFFER } from "./dispatch"; | ||
| export { msg, flatbuffers }; |
There was a problem hiding this comment.
I suspect the bundle size increase is a result of this line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some clean up reorganization around flatbuffer/minimal dispatch code. This is prep for adding a JSON dispatcher.