Start porting flatbuffer ops to JSON #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
force-pushed
the
json_ops
branch
2 times, most recently
from
2774da2
to
90c00ec
Compare
Converts env(), exit(), execPath(), utime() and utimeSync() to use JSON instead of flatbuffers.
ry
force-pushed
the
json_ops
branch
2 times, most recently
from
28f7778
to
846d91b
Compare
Merged
bartlomieju
reviewed
Aug 22, 2019
Closed
cli/Cargo.toml
Outdated
| @@ -37,7 +37,7 @@ regex = "1.2.1" | |||
| remove_dir_all = "0.5.2" | |||
| ring = "~0.14.6" | |||
| rustyline = "5.0.2" | |||
| serde = "1.0.99" | |||
| serde = { version = "1.0.99", features = ["derive"] } | |||
There was a problem hiding this comment.
Do this as a separate PR, so we can keep the cargo an gn builds in sync.
piscisaureus
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #2121
depends on #2796
next pr contains some examples of ops that have been ported #2802