Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: enable 'derive' feature of 'serde' crate #2808

Merged
merged 1 commit into from
Aug 23, 2019
Merged

build: enable 'derive' feature of 'serde' crate #2808

merged 1 commit into from
Aug 23, 2019

Conversation

piscisaureus
Copy link
Member

For #2799

@piscisaureus piscisaureus requested a review from ry August 23, 2019 00:29
@piscisaureus piscisaureus mentioned this pull request Aug 23, 2019
Merged
ry
ry approved these changes Aug 23, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... tho I was able to use Serde derive fine without these GN changes.

@piscisaureus piscisaureus merged commit 47c2163 into denoland:master Aug 23, 2019
@piscisaureus piscisaureus deleted the derive_feature branch August 23, 2019 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piscisaureus @ry