Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: share HTTP server between tests #3966

Merged
merged 2 commits into from
Feb 11, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Feb 11, 2020

Blocked by #3967

@bartlomieju bartlomieju force-pushed the chore_share_http_server branch from 8bc4bcd to 2989735 Compare February 11, 2020 12:10
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice clean up

@bartlomieju bartlomieju merged commit e6167c7 into denoland:master Feb 11, 2020
@bartlomieju bartlomieju deleted the chore_share_http_server branch February 11, 2020 21:02
geoFlux added a commit to geoFlux/deno that referenced this pull request Feb 14, 2020
* master:
  v0.33.0
  fix: appended CRLF to end of trailer headers (denoland#3989)
  Clean up fmt flags and path handling (denoland#3988)
  Improvements to bundling. (denoland#3965)
  fix: Correctly determine a --cached-only error (denoland#3979)
  chore: share HTTP server between tests (denoland#3966)
  dont use env vars in multiple installer tests (denoland#3967)
  feat(node): add EventEmitter.errorMonitor (denoland#3960)
  fix(file_server): don't crash on "%" pathname (denoland#3953)
  update references to testing/mod.ts in manual (denoland#3973)
bartlomieju added a commit to bartlomieju/deno that referenced this pull request Feb 27, 2020
piscisaureus pushed a commit that referenced this pull request Feb 28, 2020
mhvsa pushed a commit to mhvsa/deno that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants