installer: don't use env vars in multiple tests #3967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoFlux
added a commit
to geoFlux/deno
that referenced
this pull request
Feb 14, 2020
* master: v0.33.0 fix: appended CRLF to end of trailer headers (denoland#3989) Clean up fmt flags and path handling (denoland#3988) Improvements to bundling. (denoland#3965) fix: Correctly determine a --cached-only error (denoland#3979) chore: share HTTP server between tests (denoland#3966) dont use env vars in multiple installer tests (denoland#3967) feat(node): add EventEmitter.errorMonitor (denoland#3960) fix(file_server): don't crash on "%" pathname (denoland#3953) update references to testing/mod.ts in manual (denoland#3973)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes transient failure for installer tests. Two tests were settings env vars - because Rust tests are run in parallel sometimes one test overridden env vars of other test. Rewritten to use custom path.