Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: providing empty source code for missing compiled files #6760

Merged
merged 7 commits into from
Jul 17, 2020
Merged

fix: providing empty source code for missing compiled files #6760

merged 7 commits into from
Jul 17, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Jul 15, 2020 •
edited
Loading

Fixes #6746

@bartlomieju bartlomieju mentioned this pull request Jul 15, 2020
Closed
@bartlomieju
Copy link
Member Author

@kitsonk PTAL, I did as you suggested in #6746 by providing empty source code for any missing compiled file, along with a hint regarding type imports/exports.

@bartlomieju bartlomieju changed the title [WIP] fix: type only imports in TS files fix: providing empty source code for missing compiled files Jul 16, 2020
@bartlomieju bartlomieju requested a review from ry July 16, 2020 11:58
ry
ry approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 6e34f6a into denoland:master Jul 17, 2020
@bartlomieju bartlomieju deleted the fix_type_only_imports branch July 17, 2020 13:50
This was referenced Jul 19, 2020
Closed
Closed
@lucacasonato lucacasonato mentioned this pull request Aug 16, 2020
Closed
@nayeemrmn nayeemrmn mentioned this pull request Nov 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: type only files are not emitted
2 participants
@bartlomieju @ry