Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli/program_state): Remove redundant compiler warning #8377

Closed
wants to merge 2 commits into from

Conversation

nayeemrmn
Copy link
Collaborator

As I see it, #6760 introduced a valid fix for a strictly internal quirk where type-only modules used to cause problems. But the accompanying warning isn't necessary because it affects valid user code.

@bartlomieju bartlomieju requested a review from kitsonk November 14, 2020 12:58
@kitsonk
Copy link
Contributor

kitsonk commented Nov 14, 2020

I totally disagree with the intent of this PR. The message is not redundant. People should not be importing type only d.ts files via import and should instead use import type, as the resulting code is not --no-check safe, and can/will result in other errors. If people are trying to import ambient types, they should be using import at all but instead using triple slash directives.

@nayeemrmn
Copy link
Collaborator Author

😓 I could have sworn I saw this warning without using any d.ts files, but I can't reproduce anything now. Closing.

@nayeemrmn nayeemrmn closed this Nov 16, 2020
@nayeemrmn nayeemrmn deleted the empty-source-warning branch November 16, 2020 18:07
@kitsonk
Copy link
Contributor

kitsonk commented Nov 16, 2020

@nayeemrmn there were some bugs related to #8311 that was causing this to occur incorrectly, so you or other could have incorrectly seen this (caused when another file had a diagnostic error, which was then fixed, but a dependency was not changed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants