Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

todo(semver): add parse_range_test.ts file #4309

Closed
Tracked by #4307
iuioiua opened this issue Feb 12, 2024 · 2 comments
Closed
Tracked by #4307

todo(semver): add parse_range_test.ts file #4309

iuioiua opened this issue Feb 12, 2024 · 2 comments
Assignees
@javihernant
Labels
good first issue Good for newcomers PR welcome A pull request for this issue would be welcome semver

Comments

@iuioiua
Copy link
Contributor

iuioiua commented Feb 12, 2024 •
edited
Loading

This can be done by taking parts of the tests from semver/range_test.ts and repurposing them just for parseRange().
@iuioiua iuioiua mentioned this issue Feb 12, 2024
Closed
4 tasks
@iuioiua iuioiua added good first issue Good for newcomers semver PR welcome A pull request for this issue would be welcome labels Feb 12, 2024
@javihernant
Copy link
Contributor

I'd like to work on this one

javihernant added a commit to javihernant/deno_std that referenced this issue Feb 18, 2024
@javihernant
chore(semver): add test for parse_range (denoland#4309)
9cb113a
javihernant added a commit to javihernant/deno_std that referenced this issue Feb 18, 2024
@javihernant
chore(semver): add test for parse_range (denoland#4309)
4672010
javihernant added a commit to javihernant/deno_std that referenced this issue Feb 19, 2024
@javihernant
chore(semver): add tests for parse_range (denoland#4309)
bec396d
javihernant added a commit to javihernant/deno_std that referenced this issue Feb 19, 2024
@javihernant
chore(semver): add tests for parse_range (denoland#4309)
7b65ca4
javihernant added a commit to javihernant/deno_std that referenced this issue Feb 19, 2024
@javihernant
chore(semver): add tests for parse_range (denoland#4309)
04a2b27
javihernant added a commit to javihernant/deno_std that referenced this issue Feb 22, 2024
@javihernant
chore(semver): add tests for parse_range (denoland#4309)
e8ab053
@iuioiua
Copy link
Contributor Author

iuioiua commented Feb 23, 2024

Completed in #4345.

@iuioiua iuioiua closed this as completed Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javihernant javihernant

Labels
good first issue Good for newcomers PR welcome A pull request for this issue would be welcome semver
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iuioiua @javihernant