test(semver): add test for parseRange()
#4345
Conversation
|
This is just a draft. I am not sure if test should be implemented like this. Can anyone confirm? Also, I am new at TS and probably there's a more idiomatic way to write it. So, please, I am happy to hear about anything wrong or that can be improved. Ty!! |
semver/parse_range_test.ts
Outdated
| return true; | ||
| } | ||
|
|
||
| function equalRanges( |
There was a problem hiding this comment.
I don't think we need this util. We can use assertEquals to compare nested objects.
|
This new commit contains one way to test |
I think that's just fine. Tests are for catching such changes. We'll update the test expectation in that cases if the change looks reasonable. |
semver/parse_range_test.ts
Outdated
| } | ||
| }); | ||
|
|
||
| Deno.test("parseHyphenRanges", () => { |
There was a problem hiding this comment.
We have some rule for naming test cases: https://github.com/denoland/deno_std/blob/main/.github/CONTRIBUTING.md#tests
This case probably should be something like:
| Deno.test("parseHyphenRanges", () => { | |
| Deno.test("parseRange() parses ranges with hyphens", () => { |
Can you also update the other test cases alike?
javihernant
force-pushed
the
mersey
branch
2 times, most recently
from
bec396d
to
7b65ca4
Compare
kt3k
changed the title
semver/parse_range_test.ts
Outdated
| ["^1.2.3+build", [ | ||
| [ | ||
| { operator: ">=", major: 1, minor: 2, patch: 3, prerelease: [] }, | ||
| { operator: "<", major: 2, minor: 0, patch: 0 }, | ||
| ], | ||
| ]], |
There was a problem hiding this comment.
This one seems the same as the above one?
semver/parse_range_test.ts
Outdated
| }, | ||
| ], | ||
| ]], | ||
| ["^1.2.3", [ |
| ["=1.2.3", [ | ||
| [ | ||
| { | ||
| operator: undefined, |
There was a problem hiding this comment.
I think that previously was operator:"". I'm going to check this
semver/parse_range_test.ts
Outdated
| }, | ||
| ], | ||
| ]], | ||
| [">=1.0.0", [ |
| }, | ||
| ], | ||
| ]], | ||
| [">1.0.0", [ |
|
@javihernant Thanks for updating! Looks close to be merged, but I found several cases were repeated with completely the same input and expectations. Can you clean up them? |
semver/parse_range_test.ts
Outdated
| }, | ||
| ], | ||
| ]], | ||
| ["<=2.0.0", [ |
semver/parse_range_test.ts
Outdated
| }, | ||
| ], | ||
| ]], | ||
| ["<=2.0.0", [ |
| }, | ||
| ], | ||
| ]], | ||
| ["<2.0.0", [ |
semver/parse_range_test.ts
Outdated
| }, | ||
| ], | ||
| ]], | ||
| [">=0.2.3 || <0.0.1", [ |
semver/parse_range_test.ts
Outdated
| { operator: "<", major: 3, minor: 0, patch: 0 }, | ||
| ], | ||
| ]], | ||
| ["1.2.x || 2.x", [ |
| { operator: "<", major: 3, minor: 0, patch: 0 }, | ||
| ], | ||
| ]], | ||
| ["2.*.*", [ |
semver/parse_range_test.ts
Outdated
| { operator: "<", major: 3, minor: 0, patch: 0 }, | ||
| ], | ||
| ]], | ||
| ["1.2.* || 2.*", [ |
semver/parse_range_test.ts
Outdated
| { operator: "<", major: 0, minor: 1, patch: 0 }, | ||
| ], | ||
| ]], | ||
| ["~0.0.1", [ |
| { operator: "<", major: 2, minor: 5, patch: 0 }, | ||
| ], | ||
| ]], | ||
| ["~2.4", [ |
semver/parse_range_test.ts
Outdated
| { operator: "<", major: 3, minor: 3, patch: 0 }, | ||
| ], | ||
| ]], | ||
| ["~>3.2.1", [ |
| { operator: "<", major: 2, minor: 0, patch: 0 }, | ||
| ], | ||
| ]], | ||
| ["~>1", [ |
semver/parse_range_test.ts
Outdated
| { operator: "<", major: 0, minor: 0, patch: 2 }, | ||
| ], | ||
| ]], | ||
| ["^0.0.1", [ |
semver/parse_range_test.ts
Outdated
| { operator: "<", major: 0, minor: 0, patch: 2 }, | ||
| ], | ||
| ]], | ||
| ["^1.2.3", [ |
semver/parse_range_test.ts
Outdated
| { operator: "<", major: 2, minor: 0, patch: 0 }, | ||
| ], | ||
| ]], | ||
| ["^1.2.3", [ |
semver/parse_range_test.ts
Outdated
| { operator: "<", major: 2, minor: 0, patch: 0 }, | ||
| ], | ||
| ]], | ||
| ["^1.2", [ |
| }, | ||
| ], | ||
| ]], | ||
| ["^1.2.3", [ |
|
I think I found too many duplicated entries.. I might be missing something.. |
|
Updated the tests to remove all duplicates. I'm sorry I left so many!!! |
iuioiua
changed the title
parseRange()
…0/deno_std into fix/expect-custom-equality-case * 'fix/expect-custom-equality-case' of github.com:eryue0220/deno_std: (63 commits) docs: link to `assertThrows()` and `assertRejects()` (denoland#4395) chore(log): sync `level` and `levelName` in BaseHandler (denoland#4393) docs: ignore bad snippet examples (denoland#4388) chore(media_types): format test names (denoland#4380) docs: clarify underscore guidance in README (denoland#4385) feat(collections): add `pick` and `omit` (denoland#4218) chore(msgpack): format test names (denoland#4381) refactor(encoding): prepare for `noUncheckedIndexedAccess` (denoland#4275) refactor(streams): prepare for `noUncheckedIndexedAccess` (denoland#4377) chore: fix .editorconfig syntax (denoland#4376) chore(semver): remove legacy `Range.ranges` object definition (denoland#4374) chore(semver): move breaking versions (denoland#4372) refactor(semver): rename `comparatorFormat()` to `formatComparator()` (denoland#4373) test(semver): add test for parse_range (denoland#4345) chore: use 'release' event for triggering jsr publish (denoland#4370) chore(http): fix spawned tests after migration script (denoland#4368) chore(crypto): move test scripts to own files (denoland#4367) 0.217.0 (denoland#4369) build: update _ to - in workspace converter script (denoland#4357) chore(media_types): move `extensions` utility (denoland#4358) ...
No description provided.