Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(semver): rename comparatorFormat() to formatComparator() #4373

Merged
merged 1 commit into from
Feb 23, 2024
Merged

refactor(semver): rename comparatorFormat() to formatComparator() #4373

merged 1 commit into from
Feb 23, 2024

Conversation

timreichen
Copy link
Contributor

@timreichen timreichen commented Feb 22, 2024 •
edited
Loading

Changes

  • renames comparatorFormat() to formatComparator()

Reasons

  • javascript generally has a verb-first convention
  • this aligns with parseComparator()
  • this function and file are private, so no breaking changes

@timreichen timreichen requested a review from kt3k as a code owner February 22, 2024 23:40
iuioiua
iuioiua approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@iuioiua iuioiua changed the title rename(semver): rename comparatorFormat() to formatComparator() refactor(semver): rename comparatorFormat() to formatComparator() Feb 23, 2024
@iuioiua iuioiua merged commit 6e6eff5 into denoland:main Feb 23, 2024
12 checks passed
eryue0220 added a commit to eryue0220/deno_std that referenced this pull request Feb 28, 2024
@eryue0220
Merge branch 'fix/expect-custom-equality-case' of github.com:eryue022…
810250f 
…0/deno_std into fix/expect-custom-equality-case

* 'fix/expect-custom-equality-case' of github.com:eryue0220/deno_std: (63 commits)
  docs: link to `assertThrows()` and `assertRejects()` (denoland#4395)
  chore(log): sync `level` and `levelName` in BaseHandler (denoland#4393)
  docs: ignore bad snippet examples (denoland#4388)
  chore(media_types): format test names (denoland#4380)
  docs: clarify underscore guidance in README (denoland#4385)
  feat(collections): add `pick` and `omit` (denoland#4218)
  chore(msgpack): format test names (denoland#4381)
  refactor(encoding): prepare for `noUncheckedIndexedAccess` (denoland#4275)
  refactor(streams): prepare for `noUncheckedIndexedAccess` (denoland#4377)
  chore: fix .editorconfig syntax (denoland#4376)
  chore(semver): remove legacy `Range.ranges` object definition (denoland#4374)
  chore(semver): move breaking versions (denoland#4372)
  refactor(semver): rename `comparatorFormat()` to `formatComparator()` (denoland#4373)
  test(semver): add test for parse_range (denoland#4345)
  chore: use 'release' event for triggering jsr publish (denoland#4370)
  chore(http): fix spawned tests after migration script (denoland#4368)
  chore(crypto): move test scripts to own files (denoland#4367)
  0.217.0 (denoland#4369)
  build: update _ to - in workspace converter script (denoland#4357)
  chore(media_types): move `extensions` utility (denoland#4358)
  ...
@timreichen timreichen deleted the semver_rename_comparator_format branch July 2, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
semver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timreichen @iuioiua