Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix .editorconfig syntax #4376

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Conversation

javihernant
Copy link
Contributor

fix .editorconfig to make .js/.ts settings take effect.

Previously those settings were being ignored

@javihernant javihernant requested a review from kt3k as a code owner February 23, 2024 10:44
.editorconfig Outdated
@@ -1,6 +1,6 @@
root = true

[*.ts,*.js]
[*{.ts,*.js}]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be the below?

Suggested change
[*{.ts,*.js}]
[*{.ts,.js}]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the below would be better?

Suggested change
[*{.ts,*.js}]
[*.{ts,js}]

@kt3k kt3k changed the title fix(deno_std): fix .editorconfig syntax chore(deno_std): fix .editorconfig syntax Feb 23, 2024
@kt3k kt3k changed the title chore(deno_std): fix .editorconfig syntax chore: fix .editorconfig syntax Feb 23, 2024
fix .editorconfig to make .js/.ts settings take effect.

Previously those settings were being ignored
@javihernant
Copy link
Contributor Author

javihernant commented Feb 23, 2024

Updated commit.

From editorconfig.org:

# Matches multiple files with brace expansion notation
# Set default charset
[*.{js,py}]
charset = utf-8

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kt3k kt3k merged commit 58cb4ba into denoland:main Feb 24, 2024
12 checks passed
eryue0220 added a commit to eryue0220/deno_std that referenced this pull request Feb 28, 2024
…0/deno_std into fix/expect-custom-equality-case

* 'fix/expect-custom-equality-case' of github.com:eryue0220/deno_std: (63 commits)
  docs: link to `assertThrows()` and `assertRejects()` (denoland#4395)
  chore(log): sync `level` and `levelName` in BaseHandler (denoland#4393)
  docs: ignore bad snippet examples (denoland#4388)
  chore(media_types): format test names (denoland#4380)
  docs: clarify underscore guidance in README (denoland#4385)
  feat(collections): add `pick` and `omit` (denoland#4218)
  chore(msgpack): format test names (denoland#4381)
  refactor(encoding): prepare for `noUncheckedIndexedAccess` (denoland#4275)
  refactor(streams): prepare for `noUncheckedIndexedAccess` (denoland#4377)
  chore: fix .editorconfig syntax (denoland#4376)
  chore(semver): remove legacy `Range.ranges` object definition (denoland#4374)
  chore(semver): move breaking versions (denoland#4372)
  refactor(semver): rename `comparatorFormat()` to `formatComparator()` (denoland#4373)
  test(semver): add test for parse_range (denoland#4345)
  chore: use 'release' event for triggering jsr publish (denoland#4370)
  chore(http): fix spawned tests after migration script (denoland#4368)
  chore(crypto): move test scripts to own files (denoland#4367)
  0.217.0 (denoland#4369)
  build: update _ to - in workspace converter script (denoland#4357)
  chore(media_types): move `extensions` utility (denoland#4358)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants