Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(http): fix spawned tests after migration script #4368

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Feb 22, 2024

Adding --config deno.json seems to be needed for these tests to complete successfully after running the workspaces migration script. Shouldn't deno.json be automatically detected and loaded? This appears to be a bug.

I can confirm that these tests now pass after running the migration script.

Towards #4346

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kt3k
Copy link
Member

kt3k commented Feb 22, 2024

Shouldn't deno.json be automatically detected and loaded? This appears to be a bug.

We have http/deno.json after running the convert script. Is it possible that file affects the auto-discovery of deno.json at the top level?

@iuioiua
Copy link
Collaborator Author

iuioiua commented Feb 22, 2024

Note to self: test the affected files if/when a bug is confirmed and fixed.

@iuioiua iuioiua merged commit 241c6b2 into main Feb 22, 2024
10 checks passed
@iuioiua iuioiua deleted the fix-http-spawned-tests branch February 22, 2024 04:40
eryue0220 added a commit to eryue0220/deno_std that referenced this pull request Feb 28, 2024
…0/deno_std into fix/expect-custom-equality-case

* 'fix/expect-custom-equality-case' of github.com:eryue0220/deno_std: (63 commits)
  docs: link to `assertThrows()` and `assertRejects()` (denoland#4395)
  chore(log): sync `level` and `levelName` in BaseHandler (denoland#4393)
  docs: ignore bad snippet examples (denoland#4388)
  chore(media_types): format test names (denoland#4380)
  docs: clarify underscore guidance in README (denoland#4385)
  feat(collections): add `pick` and `omit` (denoland#4218)
  chore(msgpack): format test names (denoland#4381)
  refactor(encoding): prepare for `noUncheckedIndexedAccess` (denoland#4275)
  refactor(streams): prepare for `noUncheckedIndexedAccess` (denoland#4377)
  chore: fix .editorconfig syntax (denoland#4376)
  chore(semver): remove legacy `Range.ranges` object definition (denoland#4374)
  chore(semver): move breaking versions (denoland#4372)
  refactor(semver): rename `comparatorFormat()` to `formatComparator()` (denoland#4373)
  test(semver): add test for parse_range (denoland#4345)
  chore: use 'release' event for triggering jsr publish (denoland#4370)
  chore(http): fix spawned tests after migration script (denoland#4368)
  chore(crypto): move test scripts to own files (denoland#4367)
  0.217.0 (denoland#4369)
  build: update _ to - in workspace converter script (denoland#4357)
  chore(media_types): move `extensions` utility (denoland#4358)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants