chore: use 'release' event for triggering jsr publish #4370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
commented
Feb 22, 2024
| run: deno publish --dry-run | ||
|
|
||
| - name: Publish (real) | ||
| if: startsWith(github.ref, 'refs/tags/') | ||
| if: github.event_name == 'release' |
There was a problem hiding this comment.
You can find the example of this expression, for example, in https://github.com/google/brotli/blob/ccec9628e49208173c9a8829ff66d0d7f6ceff5f/.github/workflows/release.yaml#L118
kt3k
commented
Feb 22, 2024
| @@ -2,9 +2,9 @@ name: workspace publish | |||
|
|
|||
| on: | |||
| push: | |||
| branches: [main, workspace_publish] | |||
There was a problem hiding this comment.
workspace_publish branch doesn't exist anymore
iuioiua
approved these changes
Feb 22, 2024
eryue0220
added a commit
to eryue0220/deno_std
that referenced
this pull request
Feb 28, 2024
…0/deno_std into fix/expect-custom-equality-case * 'fix/expect-custom-equality-case' of github.com:eryue0220/deno_std: (63 commits) docs: link to `assertThrows()` and `assertRejects()` (denoland#4395) chore(log): sync `level` and `levelName` in BaseHandler (denoland#4393) docs: ignore bad snippet examples (denoland#4388) chore(media_types): format test names (denoland#4380) docs: clarify underscore guidance in README (denoland#4385) feat(collections): add `pick` and `omit` (denoland#4218) chore(msgpack): format test names (denoland#4381) refactor(encoding): prepare for `noUncheckedIndexedAccess` (denoland#4275) refactor(streams): prepare for `noUncheckedIndexedAccess` (denoland#4377) chore: fix .editorconfig syntax (denoland#4376) chore(semver): remove legacy `Range.ranges` object definition (denoland#4374) chore(semver): move breaking versions (denoland#4372) refactor(semver): rename `comparatorFormat()` to `formatComparator()` (denoland#4373) test(semver): add test for parse_range (denoland#4345) chore: use 'release' event for triggering jsr publish (denoland#4370) chore(http): fix spawned tests after migration script (denoland#4368) chore(crypto): move test scripts to own files (denoland#4367) 0.217.0 (denoland#4369) build: update _ to - in workspace converter script (denoland#4357) chore(media_types): move `extensions` utility (denoland#4358) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
workspace publishworkflow.This workflow wasn't triggered for the latest 2 tags for some reason (It was triggered for 0.215.0 though).
(This might be caused by the behavior described in this page, or by the misconfig of PAT)
This change uses
releaseevent (triggered when the github release is published) to avoid the above issue.