csv - parse takes undefined opt

[dsherret]

Kind of confusing that the opt parameter here is opt?: undefined:

https://github.com/denoland/deno_std/blob/74fc8ff920991c4c79fa4c7647d855e5780db64c/csv/parse.ts#L326

...shouldn't that just not exist given the other overloads?

[fdemir]

Should we remove the opt?: undefined from this overload?

[dsherret]

Yeah, I think it should just be export function parse(input: string): string[][];

[Wencho8]

I can work on this. Removing the extra comments and the opt parameter.

[iuioiua]

Completed in #4598

[dandv]

Not sure what the status of this is, but I'm giving Deno a first try with a simple task: manipulate a CSV. Trying to figure out the parameters for parse in WebStorm is tricky, because the options object doesn't seem to be documented (only input is), but is used in the example:

I'm using jsr:@std/csv@^0.224.1.

[BlackAsLight]

Not sure what the status of this is, but I'm giving Deno a first try with a simple task: manipulate a CSV. Trying to figure out the parameters for parse in WebStorm is tricky, because the options object doesn't seem to be documented (only input is), but is used in the example:

I'm using jsr:@std/csv@^0.224.1.

Looking at the documentation, parse has two overloads, with opt being a generic type that extends ParseOptions. Why opt isn't a Partial<ParseOptions> is unknown to me.

[iuioiua]

Re-opening this issue. It's weird that parse() is generic and could be cleaned up and documented better.

Edit: I'll keep this open until CSV documentation is reviewed as part of achieving stabilization. Then, we can see if the documentation satisfies the shortcomings pointed out here.