Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csv): remove unused opt parameter #4598

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

Wencho8
Copy link
Contributor

@Wencho8 Wencho8 commented Apr 16, 2024

This was made according to the issue #4545 inside the file deno_std/csv/parse.ts

@Wencho8 Wencho8 requested a review from kt3k as a code owner April 16, 2024 15:33
@github-actions github-actions bot added the csv label Apr 16, 2024
@CLAassistant
Copy link

CLAassistant commented Apr 16, 2024

CLA assistant check
All committers have signed the CLA.

@Wencho8 Wencho8 changed the title Remove unused opt parameter (issue #4545), since the other overloads already handle it. Removed unused opt parameter (issue #4545), since the other overloads already handle it. Apr 16, 2024
@Wencho8 Wencho8 changed the title Removed unused opt parameter (issue #4545), since the other overloads already handle it. fix(csv): Remove unused 'opt' parameter (#4545) Apr 16, 2024
@iuioiua iuioiua changed the title fix(csv): Remove unused 'opt' parameter (#4545) fix(csv): remove unused opt parameter Apr 16, 2024
Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you.

@iuioiua iuioiua enabled auto-merge (squash) April 16, 2024 21:53
@iuioiua
Copy link
Collaborator

iuioiua commented Apr 16, 2024

Closes #4545

@iuioiua iuioiua merged commit 31018f1 into denoland:main Apr 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants