Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ws send() masks frames which it must not when sending to the client #614

Closed
drdreo opened this issue Sep 26, 2019 · 1 comment · Fixed by #616
Closed

ws send() masks frames which it must not when sending to the client #614

drdreo opened this issue Sep 26, 2019 · 1 comment · Fixed by #616

Comments

@drdreo
Copy link

drdreo commented Sep 26, 2019

The current mod.ts in std/ws masks the frame on send() which errors in the browser with the message: "A server must not mask any frames that it sends to the client."

Playing around with a websocket chat as an example: https://github.com/drdreo/deno-chat
I copied the mod.ts and simply not creating the mask fixed that error for me.

this.mask = opts.mask ;
// this.mask = opts.mask || createMask();
@keroxp
Copy link
Contributor

keroxp commented Sep 28, 2019

Correct. This may be violation of WebSocket standard on server side.

@ry ry closed this as completed in #616 Sep 28, 2019
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this issue Oct 24, 2024
This aligns with Deno Deploy's `DENO_KV_ACCESS_TOKEN` environment
variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants