Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [ws] mask must not be set by default for server #616

Merged
merged 1 commit into from
Sep 28, 2019
Merged

fix: [ws] mask must not be set by default for server #616

merged 1 commit into from
Sep 28, 2019

Conversation

keroxp
Copy link
Contributor

@keroxp keroxp commented Sep 28, 2019

ry
ry approved these changes Sep 28, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit de99fcb into denoland:master Sep 28, 2019
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
@keroxp @ry
fix(ws) mask must not be set by default for server (denoland/std#616)
04e4f10 
Original: denoland/std@de99fcb
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this pull request Oct 24, 2024
@iuioiua
chore: remove deleteItem() (denoland#616)
7e40f27 
This function is not used anywhere in the codebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ws send() masks frames which it must not when sending to the client
2 participants
@keroxp @ry