Added EOL detect / format #289
Merged
+64
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-f1
reviewed
Mar 18, 2019
fs/eol.ts
Outdated
| if (!_eol) { | ||
| return content; | ||
| } else if (_eol === eol) { | ||
| return content; |
There was a problem hiding this comment.
This doesn’t work if the file has mixed newlines, since detect only looks at the first newline.
There was a problem hiding this comment.
I was really wondering about this case (for detect). Is that really possible? And in this case, what would you do? Because the file is somehow invalid no? (fixing the mixed format)
ry
approved these changes
Apr 7, 2019
|
I'll add the detect mixed in a further PR and let's discuss about the encoding directory in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As files may be used in a Linux env but may come from a windows env, EOL is not the same. Added a FS helper for the detection / format. ATM it gets a string input, maybe coupled with readFileStr ( #276 ) in the future?