Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EOL add mixed detection #325

Merged
merged 2 commits into from
Apr 13, 2019
Merged

EOL add mixed detection #325

merged 2 commits into from
Apr 13, 2019

Conversation

zekth
Copy link
Contributor

@zekth zekth commented Apr 7, 2019

Add mixed detection
deleted double entry for io/test

Like mentionned in : #289

Add mixed detection
deleted double entry for io/test
@ry
Copy link
Member

ry commented Apr 8, 2019

I'd rather if we did the move separately. My idea is that we could also move

//toml/toml.ts -> //encoding/toml.ts
//fs/eol.ts -> //encoding/eol.ts
//bytes/bytes.ts -> //encoding/bytes.ts

I'm not sure if "encoding" is a good name tho. Basically I'd like to combine all the "file formats" into one place. Maybe @keroxp has a better suggestion for organization?

@ry
Copy link
Member

ry commented Apr 8, 2019

For this PR please undo the moves, but leave the other changes. Update the commit message.

@zekth zekth changed the title EOL move to encoding EOL add mixed detection Apr 8, 2019
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit bb92c44 into denoland:master Apr 13, 2019
@zekth zekth deleted the encoding branch April 13, 2019 20:17
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants