fix(fs/walk): return symbolic links (#1359) #3455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like reasonable changes to me. Thanks for your suggestions! Can you take a look into the test failures in |
joehillen
force-pushed
the
fix/1359/walk-return-links
branch
2 times, most recently
from
ce4c0fc to
4c23486
Compare
|
@kt3k Should be fixed now. Sorry for the delay. It's been a crazy month. |
Symbolic links were not returned. This means that `walk()` is not listing all the contents of a directory. Some use cases for this is are: - Copying a directory recursively. - Finding invalid symbolic links. - Modify link targets without resolving them. Other changes: - walk_test.ts: Rename `walkArray()` to `collectPaths()` because it is more descriptive. - walk_test.ts: Add `collectEntries()`
joehillen
force-pushed
the
fix/1359/walk-return-links
branch
from
4c23486 to
c76a54f
Compare
|
I think I fixed the test failure. I don't have access to windows, so I can't be sure until it runs again |
|
Sorry for the delay in review. After reading the original issue again, I think we should add Closing this one in favor of #3464, which implements Thanks for creating this PR anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbolic links were not returned. This means that
walk()is not listing all the contents of a directory.Some use cases for this is are:
Other changes:
walkArray()tocollectPaths()because it is more descriptive.collectEntries()closes #1359