Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(assert): cleanup _diff.ts #4086

Closed
wants to merge 8 commits into from
Closed

refactor(assert): cleanup _diff.ts #4086

wants to merge 8 commits into from

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Jan 4, 2024 •
edited
Loading

This aims to make some of the logic a little easier to understand.

@github-actions github-actions bot added the assert label Jan 4, 2024
@iuioiua iuioiua mentioned this pull request Jan 4, 2024
Closed
@iuioiua iuioiua marked this pull request as ready for review January 10, 2024 02:12
@iuioiua iuioiua requested a review from kt3k as a code owner January 10, 2024 02:12
kt3k
kt3k reviewed Jan 10, 2024
View reviewed changes
assert/_diff.ts Outdated Show resolved Hide resolved
@iuioiua iuioiua requested a review from kt3k January 11, 2024 06:46
@iuioiua iuioiua marked this pull request as draft January 11, 2024 06:47
@iuioiua
Copy link
Collaborator Author

iuioiua commented Jan 11, 2024

Actually, closing as this undoes some of the work from #4121. I might approach this later.

@iuioiua iuioiua closed this Jan 11, 2024
@iuioiua iuioiua deleted the cleanup-assert-_diff branch January 11, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
assert
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @kt3k