Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cli): prepare for noUncheckedIndexedAccess #4121

Merged
merged 6 commits into from
Jan 10, 2024
Merged

refactor(cli): prepare for noUncheckedIndexedAccess #4121

merged 6 commits into from
Jan 10, 2024

Conversation

syhol
Copy link
Contributor

@syhol syhol commented Jan 5, 2024 •
edited
Loading

Handling all noUncheckedIndexedAccess issues for the cli module, tracked in #4040

@syhol syhol requested a review from kt3k as a code owner January 5, 2024 23:45
@github-actions github-actions bot added the cli label Jan 5, 2024
@syhol syhol changed the title refactor(cli): prepare for noUncheckedIndexedAccess refactor(cli): prepare for noUncheckedIndexedAccess Jan 5, 2024
syhol
syhol commented Jan 6, 2024
View reviewed changes
cli/parse_args.ts Show resolved Hide resolved
syhol
syhol commented Jan 6, 2024
View reviewed changes
cli/parse_args.ts Show resolved Hide resolved
iuioiua
iuioiua suggested changes Jan 8, 2024
View reviewed changes
cli/parse_args.ts Outdated Show resolved Hide resolved
cli/parse_args.ts Outdated Show resolved Hide resolved
syhol and others added 2 commits January 9, 2024 12:20
@iuioiua iuioiua mentioned this pull request Jan 10, 2024
Closed
@syhol syhol mentioned this pull request Jan 10, 2024
Closed
iuioiua
iuioiua approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made just a couple of tweaks. Now, LGTM! Thank you, Simon.

@iuioiua iuioiua enabled auto-merge (squash) January 10, 2024 10:04
@iuioiua iuioiua merged commit cdab4c6 into denoland:main Jan 10, 2024
10 checks passed
@iuioiua iuioiua mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syhol @iuioiua