deprecation(semver): rename rangeFormat() to formatRange()
#4090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
suggested changes
Jan 4, 2024
|
I don't see the reason of the deprecation. Is this discussed somewhere? |
Javascript generally has a verb-first convention for functions. It is highlighted in the #3948 (comment) description. |
kt3k
reviewed
Jan 5, 2024
Fair enough. |
…ichen/deno_std into semver_rename_range_format
iuioiua
approved these changes
Jan 6, 2024
timreichen
added a commit
to timreichen/std
that referenced
this pull request
Jan 8, 2024
…and#4090) Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
iuioiua
added a commit
that referenced
this pull request
Jan 11, 2024
* initial commit * Update log/logger.ts Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com> * replace WARNING with WARN * update * refactor(cli): make `Spinner` constructor options more readable (#4091) * initial commit * update * docs(testing): fix assertion deprecation notices (#4122) * refactor(assert): remove `void` return types (#4124) * fix(http): punt removal version of `unstable_cookie_map.ts` (#4125) * chore: ignore `/docs` in license checker tool (#4123) * deprecation(semver): rename `rangeFormat()` to `formatRange()` (#4090) Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com> * refactor(archive): prepare for `noUncheckedIndexedAccess` (#4110) * refactor(archive): prepare for noUncheckedIndexedAccess * adjust test to handle new TarHeader requirements * revert WARNING --------- Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com> Co-authored-by: Simon Holloway <simon@syhol.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rangeFormat()toformatRange()