Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): punt removal version of unstable_cookie_map.ts #4125

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Jan 6, 2024

This is so cookie_map.ts and unstable_cookie_map.ts can be removed at the same time. This should prevent any confusion that would otherwise arise from both files being removed at different times.

@iuioiua iuioiua requested a review from kt3k as a code owner January 6, 2024 20:53
@github-actions github-actions bot added the http label Jan 6, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 5e0b671 into main Jan 8, 2024
12 checks passed
@iuioiua iuioiua deleted the punt-unstable-cookie-map-removal branch January 8, 2024 02:38
timreichen pushed a commit to timreichen/std that referenced this pull request Jan 8, 2024
iuioiua added a commit that referenced this pull request Jan 11, 2024
* initial commit

* Update log/logger.ts

Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>

* replace WARNING with WARN

* update

* refactor(cli): make `Spinner` constructor options more readable (#4091)

* initial commit

* update

* docs(testing): fix assertion deprecation notices (#4122)

* refactor(assert): remove `void` return types (#4124)

* fix(http): punt removal version of `unstable_cookie_map.ts` (#4125)

* chore: ignore `/docs` in license checker tool (#4123)

* deprecation(semver): rename `rangeFormat()` to `formatRange()` (#4090)

Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>

* refactor(archive): prepare for `noUncheckedIndexedAccess` (#4110)

* refactor(archive): prepare for noUncheckedIndexedAccess

* adjust test to handle new TarHeader requirements

* revert WARNING

---------

Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
Co-authored-by: Simon Holloway <simon@syhol.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants