refactor(yaml): prepare for noUncheckedIndexedAccess

yaml/_dumper/dumper.ts

@@ -4,7 +4,7 @@
 // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
 
 import { YAMLError } from "../_error.ts";
-import type { RepresentFn, StyleVariant, Type } from "../type.ts";
+import type { RepresentFn } from "../type.ts";
 import * as common from "../_utils.ts";
 import { DumperState, type DumperStateOptions } from "./dumper_state.ts";
 
@@ -129,20 +129,7 @@
 }
 
 function testImplicitResolving(state: DumperState, str: string): boolean {
-  let type: Type;
-  for (
-    let index = 0, length = state.implicitTypes.length;
-    index < length;
-    index += 1
-  ) {
-    type = state.implicitTypes[index];
-
-    if (type.resolve(str)) {
-      return true;
-    }
-  }
-
-  return false;
+  return state.implicitTypes.some((type) => type.resolve(str));
 }
 
 // [33] s-white ::= s-space | s-tab
@@ -379,7 +366,7 @@
   // tslint:disable-next-line:no-conditional-assignment
   while ((match = lineRe.exec(string))) {
     const prefix = match[1],
-      line = match[2];
+      line = match[2] || "";
     moreIndented = line[0] === " ";
     result += prefix +
       (!prevMoreIndented && !moreIndented && line !== "" ? "\n" : "") +
@@ -572,18 +559,12 @@
   const _tag = state.tag,
     objectKeyList = Object.keys(object);
 
-  let pairBuffer: string, objectKey: string, objectValue: Any;
-  for (
-    let index = 0, length = objectKeyList.length;
-    index < length;
-    index += 1
-  ) {
-    pairBuffer = state.condenseFlow ? '"' : "";
+  for (const [index, objectKey] of objectKeyList.entries()) {
+    let pairBuffer = state.condenseFlow ? '"' : "";
 
     if (index !== 0) pairBuffer += ", ";
 
-    objectKey = objectKeyList[index];
-    objectValue = object[objectKey];
+    const objectValue = object[objectKey];
 
     if (!writeNode(state, level, objectKey, false, false)) {
       continue; // Skip this pair because of invalid key;
@@ -631,29 +612,20 @@
     throw new YAMLError("sortKeys must be a boolean or a function");
   }
 
-  let pairBuffer = "",
-    objectKey: string,
-    objectValue: Any,
-    explicitPair: boolean;
-  for (
-    let index = 0, length = objectKeyList.length;
-    index < length;
-    index += 1
-  ) {
-    pairBuffer = "";
+  for (const [index, objectKey] of objectKeyList.entries()) {
+    let pairBuffer = "";
 
     if (!compact || index !== 0) {
       pairBuffer += generateNextLine(state, level);
     }
 
-    objectKey = objectKeyList[index];
-    objectValue = object[objectKey];
+    const objectValue = object[objectKey];
 
     if (!writeNode(state, level + 1, objectKey, true, true, true)) {
       continue; // Skip this pair because of invalid key.
     }
 
-    explicitPair = (state.tag !== null && state.tag !== "?") ||
+    const explicitPair = (state.tag !== null && state.tag !== "?") ||
       (state.dump && state.dump.length > 1024);
 
     if (explicitPair) {
@@ -697,11 +669,8 @@
 ): boolean {
   const typeList = explicit ? state.explicitTypes : state.implicitTypes;
 
-  let type: Type;
-  let style: StyleVariant;
-  let _result: string;
-  for (let index = 0, length = typeList.length; index < length; index += 1) {
-    type = typeList[index];
+  for (const type of typeList) {
+    let _result: string;
 
     if (
       (type.instanceOf || type.predicate) &&
@@ -712,12 +681,12 @@
       state.tag = explicit ? type.tag : "?";
 
       if (type.represent) {
-        style = state.styleMap[type.tag] || type.defaultStyle;
+        const style = state.styleMap[type.tag]! || type.defaultStyle;
 
         if (_toString.call(type.represent) === "[object Function]") {
           _result = (type.represent as RepresentFn)(object, style);
         } else if (hasOwn(type.represent, style)) {
-          _result = (type.represent as ArrayObject<RepresentFn>)[style](
+          _result = (type.represent as ArrayObject<RepresentFn>)[style]!(
             object,
             style,
           );
@@ -845,14 +814,8 @@
           inspectNode(object[idx], objects, duplicatesIndexes);
         }
       } else {
-        const objectKeyList = Object.keys(object);
-
-        for (
-          let idx = 0, length = objectKeyList.length;
-          idx < length;
-          idx += 1
-        ) {
-          inspectNode(object[objectKeyList[idx]], objects, duplicatesIndexes);
+        for (const objectKey of Object.keys(object)) {
+          inspectNode(object[objectKey], objects, duplicatesIndexes);
         }
       }
     }
@@ -868,11 +831,10 @@
 
   inspectNode(object, objects, duplicatesIndexes);
 
-  const length = duplicatesIndexes.length;
-  for (let index = 0; index < length; index += 1) {
-    state.duplicates.push(objects[duplicatesIndexes[index]]);
+  for (const idx of duplicatesIndexes) {
+    state.duplicates.push(objects[idx]);
   }
-  state.usedDuplicates = Array.from({ length });
+  state.usedDuplicates = Array.from({ length: duplicatesIndexes.length });
 }
 
 export function dump(input: Any, options?: DumperStateOptions): string {

yaml/_dumper/dumper_state.ts

@@ -16,17 +16,13 @@
 ): ArrayObject<StyleVariant> {
   if (typeof map === "undefined" || map === null) return {};
 
-  let type: Type;
   const result: ArrayObject<StyleVariant> = {};
-  const keys = Object.keys(map);
-  let tag: string, style: StyleVariant;
-  for (let index = 0, length = keys.length; index < length; index += 1) {
-    tag = keys[index];
-    style = String(map[tag]) as StyleVariant;
+  for (let tag of Object.keys(map)) {
+    let style = String(map[tag]) as StyleVariant;
     if (tag.slice(0, 2) === "!!") {
       tag = `tag:yaml.org,2002:${tag.slice(2)}`;
     }
-    type = schema.compiledTypeMap.fallback[tag];
+    const type = schema.compiledTypeMap.fallback[tag];
 
     if (
       type &&

yaml/_loader/loader.ts

@@ -202,13 +202,13 @@
       return throwError(state, "YAML directive accepts exactly one argument");
     }
 
-    const match = /^([0-9]+)\.([0-9]+)$/.exec(args[0]);
+    const match = /^([0-9]+)\.([0-9]+)$/.exec(args[0]!);
     if (match === null) {
       return throwError(state, "ill-formed argument of the YAML directive");
     }
 
-    const major = parseInt(match[1], 10);
-    const minor = parseInt(match[2], 10);
+    const major = parseInt(match[1]!, 10);
+    const minor = parseInt(match[2]!, 10);
     if (major !== 1) {
       return throwError(state, "unacceptable YAML version of the document");
     }
@@ -225,8 +225,8 @@
       return throwError(state, "TAG directive accepts exactly two arguments");
     }
 
-    const handle = args[0];
-    const prefix = args[1];
+    const handle = args[0]!;
+    const prefix = args[1]!;
 
     if (!PATTERN_TAG_HANDLE.test(handle)) {
       return throwError(
@@ -300,9 +300,7 @@
     );
   }
 
-  const keys = Object.keys(source);
-  for (let i = 0, len = keys.length; i < len; i++) {
-    const key = keys[i];
+  for (const key in Object.keys(source)) {
     if (!hasOwn(destination, key)) {
       Object.defineProperty(destination, key, {
         value: source[key],
@@ -1562,7 +1560,7 @@
         typeIndex < typeQuantity;
         typeIndex++
       ) {
-        type = state.implicitTypes[typeIndex];
+        type = state.implicitTypes[typeIndex]!;
 
         // Implicit resolving is not allowed for non-scalar types, and '?'
         // non-specific tag is only assigned to plain scalars. So, it isn't
@@ -1581,7 +1579,7 @@
     } else if (
       hasOwn(state.typeMap[state.kind || "fallback"], state.tag)
     ) {
-      type = state.typeMap[state.kind || "fallback"][state.tag];
+      type = state.typeMap[state.kind || "fallback"][state.tag]!;
 
       if (state.result !== null && type.kind !== state.kind) {
         return throwError(
@@ -1679,7 +1677,7 @@
     if (ch !== 0) readLineBreak(state);
 
     if (hasOwn(directiveHandlers, directiveName)) {
-      directiveHandlers[directiveName](state, directiveName, ...directiveArgs);
+      directiveHandlers[directiveName]!(state, directiveName, ...directiveArgs);
     } else {
       throwWarning(state, `unknown document directive "${directiveName}"`);
     }

yaml/_type/binary.ts

@@ -88,7 +88,7 @@ function representYamlBinary(object: Uint8Array): string {
       result += map[bits & 0x3f];
     }
 
-    bits = (bits << 8) + object[idx];
+    bits = (bits << 8) + object[idx]!;
   }
 
   // Dump tail

yaml/_type/float.ts

@@ -38,7 +38,7 @@
   const sign = value[0] === "-" ? -1 : 1;
   const digits: number[] = [];
 
-  if ("+-".indexOf(value[0]) >= 0) {
+  if (value[0] && "+-".indexOf(value[0]) >= 0) {
     value = value.slice(1);
   }
 

yaml/_type/pairs.ts

@@ -11,9 +11,7 @@
 function resolveYamlPairs(data: Any[][]): boolean {
   const result = Array.from({ length: data.length });
 
-  for (let index = 0; index < data.length; index++) {
-    const pair = data[index];
-
+  for (const [index, pair] of data.entries()) {
     if (_toString.call(pair) !== "[object Object]") return false;
 
     const keys = Object.keys(pair);
@@ -32,7 +30,7 @@
   const result = Array.from({ length: data.length });
 
   for (let index = 0; index < data.length; index += 1) {
-    const pair = data[index];
+    const pair = data[index]!;
 
     const keys = Object.keys(pair);
 

yaml/_type/timestamp.ts

@@ -39,9 +39,9 @@
 
   // match: [1] year [2] month [3] day
 
-  const year = +match[1];
-  const month = +match[2] - 1; // JS month starts with 0
-  const day = +match[3];
+  const year = +match[1]!;
+  const month = +match[2]! - 1; // JS month starts with 0
+  const day = +match[3]!;
 
   if (!match[4]) {
     // no hour
@@ -51,8 +51,8 @@
   // match: [4] hour [5] minute [6] second [7] fraction
 
   const hour = +match[4];
-  const minute = +match[5];
-  const second = +match[6];
+  const minute = +match[5]!;
+  const second = +match[6]!;
 
   let fraction = 0;
   if (match[7]) {
@@ -67,7 +67,7 @@
   // match: [8] tz [9] tz_sign [10] tz_hour [11] tz_minute
 
   let delta = null;
-  if (match[9]) {
+  if (match[9] && match[10]) {
     const tzHour = +match[10];
     const tzMinute = +(match[11] || 0);
     delta = (tzHour * 60 + tzMinute) * 60000; // delta in milli-seconds

yaml/schema.ts

@@ -20,12 +20,7 @@ function compileList(
   }
 
   for (const currentType of schema[name]) {
-    for (
-      let previousIndex = 0;
-      previousIndex < result.length;
-      previousIndex++
-    ) {
-      const previousType = result[previousIndex];
+    for (const [previousIndex, previousType] of result.entries()) {
       if (
         previousType.tag === currentType.tag &&
         previousType.kind === currentType.kind