Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(json): release json@1.0.0-rc.1 #5102

Merged
merged 1 commit into from
Jun 21, 2024
Merged

chore(json): release json@1.0.0-rc.1 #5102

merged 1 commit into from
Jun 21, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jun 21, 2024

Towards #5009

@iuioiua iuioiua requested a review from kt3k as a code owner June 21, 2024 04:36
@github-actions github-actions bot added the json label Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.70%. Comparing base (21e8ece) to head (d431954).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5102   +/-   ##
=======================================
  Coverage   92.70%   92.70%           
=======================================
  Files         482      482           
  Lines       38740    38740           
  Branches     5462     5462           
=======================================
  Hits        35915    35915           
  Misses       2770     2770           
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k
Copy link
Member

kt3k commented Jun 21, 2024

@std/json/common endpoint might be a bit unusual compared with the practice in other packages..? https://jsr.io/@std/json/doc/common/~

I'll suggest some changes about it

Update: done #5103

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit adc6072 into main Jun 21, 2024
15 checks passed
@iuioiua iuioiua deleted the json-rc-1 branch June 21, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants