Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(json): rename /common to /types #5103

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jun 21, 2024

Currently @std/json/common only exports JsonValue type. If some endpoint only exports utility types, it's usually called /types (ex. io/types, semver/types). This change aligned json to that practice.

What's changed

@std/json/common has been renamed to @std/json/types

Motivation

This change has been made to align the export path pattern to the rest of @std packages, such as:

  • @std/semver/types
  • @std/io/types

Migration

-import type { JsonValue } from "@std/json/common";
+import type { JsonValue } from "@std/json/types";

@kt3k
Copy link
Member Author

kt3k commented Jun 21, 2024

This one seems the only open source usage of @std/json/common. I'll send a PR to that repo after this landed
https://github.com/dahlia/deno-task-hooks/blob/f2c6bc288f2654847b06dfe9cf44f3da84f3e3d2/install.ts

@kt3k kt3k merged commit 32d46e9 into denoland:main Jun 21, 2024
13 checks passed
@kt3k kt3k deleted the json-rename-common-to-types branch June 21, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants