Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yaml): fix merge (<<) type handling in parse() #5185

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jun 28, 2024

merge type (<<) handling seems broken (ref #4457). This PR fixes it and add test cases to check it.

@github-actions github-actions bot added the yaml label Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.88%. Comparing base (de998e7) to head (1044b8c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5185      +/-   ##
==========================================
+ Coverage   93.77%   93.88%   +0.11%     
==========================================
  Files         469      469              
  Lines       37917    37917              
  Branches     5449     5457       +8     
==========================================
+ Hits        35557    35600      +43     
+ Misses       2317     2275      -42     
+ Partials       43       42       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua changed the title fix(yaml): fix merge (<<) type handling in parse fix(yaml): fix merge (<<) type handling in parse() Jun 28, 2024
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@kt3k kt3k merged commit 23e55f7 into denoland:main Jun 28, 2024
16 checks passed
@kt3k kt3k deleted the fix-yaml-merge branch June 28, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants